Skip to content

bpo-37363: Document internal audit events - #14663

Merged
miss-islington merged 3 commits into
python:masterfrom
tiran:bpo-37363-cpython-events
Sep 12, 2019
Merged

bpo-37363: Document internal audit events#14663
miss-islington merged 3 commits into
python:masterfrom
tiran:bpo-37363-cpython-events

Conversation

@tiran

@tirantiran commented Jul 9, 2019

Copy link
Copy Markdown
Member

Three internal cpython events were not documented, yet.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue37363

Comment threadDoc/c-api/init.rst Outdated
Comment threadDoc/c-api/init.rst Outdated
Comment threadDoc/c-api/sys.rst Outdated
Comment threadDoc/c-api/sys.rst Outdated

@zoobazooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with modification

Comment threadDoc/c-api/init.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. audit-event:: cpython._PySys_ClearAuditHooks "" c._PySys_ClearAuditHooks
.. audit-event:: cpython._PySys_ClearAuditHooks "" c.Py_FinalizeEx

@zooba

Copy link
Copy Markdown
Member

@tiran One more update and the this can be merged (I don't have permission to push the change to your branch myself)

Three internal cpython events were not documented, yet.
Signed-off-by: Christian Heimes <christian@python.org>
@tiran
tiranforce-pushed the bpo-37363-cpython-events branch from f5c96a1 to 3d438dbCompareSeptember 11, 2019 14:44
@tiran
tiran requested a review from zoobaSeptember 11, 2019 14:45

@matrixisematrixise left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, I have checked the result and the code. Everything seems to be correct.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
Three internal cpython events were not documented, yet.
Signed-off-by: Christian Heimes <christian@python.org>
https://bugs.python.org/issue37363
(cherry picked from commit ed4b321)
Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-16046 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2019
Three internal cpython events were not documented, yet.
Signed-off-by: Christian Heimes <christian@python.org>
https://bugs.python.org/issue37363
(cherry picked from commit ed4b321)
Co-authored-by: Christian Heimes <christian@python.org>
@zoobazooba mentioned this pull request Nov 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran@zooba@miss-islington@bedevere-bot@matrixise@the-knights-who-say-ni