Uh oh!
There was an error while loading. Please reload this page.
Docs: Add reST directives to c-api/intro#Include_Files - #14698
Conversation
Update master
Adds the following directives to the "Include Files" section: code, important, and note. Also improves the phrasing in the section where a note was added, on lines 99-101.
On line 74, was causing tests to fail
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aeros
commented
Sep 10, 2019
Thanks for the review @benjaminp. I've removed the When I had initially opened this PR, I was significantly less familiar with the usage of reST within the docs. I've gained some experience since then, and likely would not have opened a PR applying those initial changes. |
Uh oh!
There was an error while loading. Please reload this page.
miss-islington
commented
Sep 10, 2019
Thanks @aeros167 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
(cherry picked from commit b6dafe5) Co-authored-by: Kyle Stanley <aeros167@gmail.com>
bedevere-bot
commented
Sep 10, 2019
GH-15872 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit b6dafe5) Co-authored-by: Kyle Stanley <aeros167@gmail.com>
bedevere-bot
commented
Sep 10, 2019
GH-15873 is a backport of this pull request to the 3.7 branch. |
aeros
commented
Sep 10, 2019
Thanks @benjaminp! |
(cherry picked from commit b6dafe5) Co-authored-by: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit b6dafe5) Co-authored-by: Kyle Stanley <aeros167@gmail.com>
Adds the following reST directives to the "Include Files" section: code c, important, and note. Also improves the phrasing in the section where a note was added, on lines 99-101.
Since this change is quite minor and doesn't affect the actual message conveyed, I decided to go without creating an issue for it. It's mostly formatting related and an improvement to the phrasing (splits a run-on sentence into two individual ones). This could also go without a news entry, so the
skip newsandskip issuelabels would probably be appropriate.