bpo-19180: Updated reference for RFC 1750 and RFC 3280 by chkumar246 · Pull Request #148 · python/cpython

chkumar246 · 2017-02-18T08:57:42Z

RFC 1750 has been been obsoleted by RFC 4086.
RFC 3280 has been obsoleted by RFC 5280.
RFC 4366 has been obsoleted by RFC 6066.

the-knights-who-say-ni · 2017-02-18T08:57:42Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

If you don't have an account on b.p.o, please create one
Make sure your GitHub username is listed in "Your Details" at b.p.o
If you have not already done so, please sign the PSF contributor agreement
If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

Carreau

For the little effect my review can have, I approve, and comment made by OP are correct.

RFC 4366 has been obsoleted by RFC 6066.

If another reviewer is wondering, this one is already cited a couple of lines after the end the diff.

chkumar246 · 2017-02-27T09:41:57Z

Thanks for the review. Any thing more to add to this patch?

chkumar246 · 2017-03-11T06:01:35Z

@Carreau @serhiy-storchaka anything more i can improve to this patch?

orsenthil · 2017-04-04T05:37:52Z

@serhiy-storchaka - shall we move forward with this? The change looks good to me. These are See Also links which informative guidance ( like introduction to SSL/TLS from Apache site in the same list). Removing the obsolete RFC and mentioning the correct ones seems to be right thing to do.

serhiy-storchaka · 2017-04-04T06:20:57Z

RFC references should be updated only if the ssl module actually supports new RFCs and is not sticked to obsolete RFCs. I'm not a SSL expert and don't know if it is. @tiran is an expert.

There are also other references to obsolete RFCs in ssl.rst and _ssl.c. Shouldn't they be updated too?

tiran

Please update inline references, too.

Also please add RFC 6125 and link it from match_hostname.

tiran · 2017-04-04T06:42:18Z

This RFC is referenced in the documentation of RAND_add. You need to update both occurrences.

tiran · 2017-04-04T06:44:19Z

5280 is correct. Please update documentation of SSLSocket.getpeercert, too.

tiran · 2017-04-04T06:46:36Z

RFC 6066 is the successor to 4366. Please update documentation of HAS_SNI.

@tiran

@tiran's comments overrules.

ncoghlan · 2017-05-27T05:40:51Z

@chkumar246 Thanks for the initial work on this at the PyCon Pune sprints. Do you think you may be able to find time to follow up on @tiran's feedback, or would you prefer that someone else pick up the change and finish up those final details?

ncoghlan · 2017-05-28T05:03:34Z

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

chkumar246 · 2017-06-02T12:57:11Z

Sorry for the late reply, I will update the PR soon.

* RFC 1750 has been been obsoleted by RFC 4086. * RFC 3280 has been obsoleted by RFC 5280. * RFC 4366 has been obsoleted by RFC 6066.

chkumar246 · 2017-06-03T06:02:42Z

@ncoghlan @tiran Thanks for the review. I have resolved the comments, please have a look.

matrixise · 2017-06-09T09:08:36Z

Just add the url https://bugs.python.org/issue19180

matrixise · 2017-06-09T09:45:20Z

thanks @ncoghlan

…pythonGH-148) * RFC 1750 has been been obsoleted by RFC 4086. * RFC 3280 has been obsoleted by RFC 5280. * RFC 4366 has been obsoleted by RFC 6066. (cherry picked from commit 63c2c8a)

ncoghlan · 2017-06-09T11:59:51Z

Backport: #2023

Push 61 bundle (doc-only, post push-60 100/100 PURE close). (1) docs/cinderx-oracle-env-spec.md (NEW, 5632 B): Theologian-authored env-spec per supervisor 01:30:42Z PRIORITY directive after cinderx_dev oracle attempt failed at 01:16:27Z (-X jit didn't activate JIT + cross-arch confound). Spec covers build equivalence, JIT activation verification (force_compile + is_jit_compiled, NOT -X jit alone), test-harness equivalence, warmup threshold handling, observed failure modes, application procedure for W-PERF-PRE-W27C-BISECT. (2) docs/w-protocol-codify-spec.md (P11 + P12): P11 — cinderx_dev Oracle Environment Specification: rule that any cinderx_dev oracle invocation MUST follow env-spec procedure. Origin: pythia D-1777065234 python#3 deferred ~10 days; closed by 01:32:28Z env-spec landing. P12 — Alex-Pending Escalations Not Self-Liftable: caps the self-lift precedent supervisor invoked at 00:04:33Z. Rule: no agent may self-lift an Alex-pending hold; alternative paths execute on their own merits without 'hold-lift' framing. Origin: pythia python#145 python#1 + python#147 python#2 + python#148 python#2. No code changes. Reference-only push.

Push 62 (doc-only) — env-spec updated with lessons from 02:33Z dry-run + 02:39Z successful oracle execution that produced Phoenix-vs-Cinder verdict (Phoenix faster on 3/3 benches, sub-1.0x inherited from Cinder). Updates per theologian 02:41:37Z: - Phoenix JIT activation: import _cinderx FIRST, then import cinderjit (corrects v1 assumption that cinderjit was directly importable) - cinderx_dev JIT activation: from cinderx import jit; jit.force_compile - Binary paths: ~/local/cinderx_dev/python-3.12/python (corrects v1 assumption of ~/local/cinderx_dev/cinderx/python) - LD_LIBRARY_PATH + PYTHONPATH env requirements for cinderx_dev - Same-arch comparison (both ARM64 on devgpu004) verified working - Application result section: oracle verdict + per-bench numbers - Failure modes from 01:16Z (-X jit didn't activate) + 02:33Z (API enumeration gap) + both resolved methodologies Closes pythia python#148 python#4 (spec-from-single-failure shipping before empirical validation). v2 ships AFTER successful oracle execution.

the-knights-who-say-ni added the CLA not signed label Feb 18, 2017

serhiy-storchaka added the docs Documentation in the Doc dir label Feb 18, 2017

Mariatta removed the CLA not signed label Feb 21, 2017

the-knights-who-say-ni added the CLA signed label Feb 21, 2017

Carreau approved these changes Feb 22, 2017
View reviewed changes

Mariatta approved these changes Mar 11, 2017
View reviewed changes

Mariatta added the needs backport to 3.6 label Mar 11, 2017

serhiy-storchaka requested a review from tiran March 11, 2017 19:31

orsenthil previously approved these changes Apr 4, 2017
View reviewed changes

serhiy-storchaka requested a review from birkenfeld April 4, 2017 06:30

tiran requested changes Apr 4, 2017
View reviewed changes

ncoghlan added the sprint label May 28, 2017

bpo-19180: Updated reference for RFC 1750 and RFC 3280
1da8be5
* RFC 1750 has been been obsoleted by RFC 4086. * RFC 3280 has been obsoleted by RFC 5280. * RFC 4366 has been obsoleted by RFC 6066.

tiran approved these changes Jun 9, 2017
View reviewed changes

ncoghlan merged commit 63c2c8a into python:masterJun 9, 2017

ncoghlan removed the needs backport to 3.6 label Jun 9, 2017

Uh oh!

Uh oh!

Conversation

chkumar246 commented Feb 18, 2017

Uh oh!

the-knights-who-say-ni commented Feb 18, 2017

Uh oh!

Carreau left a comment

Choose a reason for hiding this comment

Uh oh!

chkumar246 commented Feb 27, 2017

Uh oh!

chkumar246 commented Mar 11, 2017

Uh oh!

orsenthil commented Apr 4, 2017

Uh oh!

serhiy-storchaka commented Apr 4, 2017

Uh oh!

tiran left a comment

Choose a reason for hiding this comment

Uh oh!

tiranApr 4, 2017

Choose a reason for hiding this comment

Uh oh!

chkumar246Jun 3, 2017

Choose a reason for hiding this comment

Uh oh!

tiranApr 4, 2017

Choose a reason for hiding this comment

Uh oh!

chkumar246Jun 3, 2017

Choose a reason for hiding this comment

Uh oh!

tiranApr 4, 2017

Choose a reason for hiding this comment

Uh oh!

chkumar246Jun 3, 2017

Choose a reason for hiding this comment

Uh oh!

ncoghlan commented May 27, 2017

Uh oh!

ncoghlan commented May 28, 2017

Uh oh!

chkumar246 commented Jun 2, 2017

Uh oh!

chkumar246 commented Jun 3, 2017

Uh oh!

matrixise commented Jun 9, 2017

Uh oh!

matrixise commented Jun 9, 2017

Uh oh!

ncoghlan commented Jun 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants