Skip to content

GH-145247: Use _PyTuple_FromPair in Modules(1) - #148000

Merged
vstinner merged 2 commits into
python:mainfrom
sergey-miryanov:feat/145247-pytuple-from-pair-use-4
Apr 2, 2026
Merged

GH-145247: Use _PyTuple_FromPair in Modules(1)#148000
vstinner merged 2 commits into
python:mainfrom
sergey-miryanov:feat/145247-pytuple-from-pair-use-4

Conversation

@sergey-miryanov

@sergey-miryanovsergey-miryanov commented Apr 2, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

First PR for usage of the _PyTuple_FromPair[Steal] in Modules

@bedevere-appbedevere-appBot mentioned this pull request Apr 2, 2026
Open
sergey-miryanov
sergey-miryanov commented Apr 2, 2026
View reviewed changes
Comment threadModules/_pickle.c
Comment threadModules/_pickle.c
@picnixz

This comment was marked as resolved.

Sign in to view
@sergey-miryanov

This comment was marked as resolved.

Sign in to view
@picnixz

This comment was marked as resolved.

Sign in to view
@sergey-miryanov

This comment was marked as resolved.

Sign in to view
vstinner
vstinner approved these changes Apr 2, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor coding style request.

Comment threadModules/_decimal/_decimal.c
Comment threadModules/_pickle.c
Comment threadModules/_pickle.c
vstinner
vstinner approved these changes Apr 2, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner merged commit 0c10066 into python:mainApr 2, 2026
52 checks passed
@sergey-miryanov

sergey-miryanov commented Apr 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks!

@pablogsalpablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@sergey-miryanov@ljfp
pythonGH-145247: Use _PyTuple_FromPair in Modules (part 1) (python#14…
d4d2da1
…8000)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sergey-miryanov@picnixz@vstinner