Skip to content

gh-148286: Fail on new UB in CI - #148168

Merged
StanFromIreland merged 11 commits into
python:mainfrom
StanFromIreland:san-ubsan
Apr 9, 2026
Merged

gh-148286: Fail on new UB in CI#148168
StanFromIreland merged 11 commits into
python:mainfrom
StanFromIreland:san-ubsan

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Apr 6, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Trying to debug a bit, it should be detecting #148166 (and also screaming about it), but it isn't. Mirroring what we do for the TSan job.

Just chucked everything in suppressions for now, they should be reviewed as it may have actual bugs.

@StanFromIrelandStanFromIreland changed the title Fail on new UBFail on new UB in CIApr 6, 2026
@StanFromIreland

StanFromIreland commented Apr 6, 2026

Copy link
Copy Markdown
MemberAuthor

I've never been so happy to see the CI fail :-)

[3](https://github.com/python/cpython/actions/runs/24037637122/job/70101135069?pr=148168#step:11:144)
==> /home/runner/work/cpython/cpython/san_log.26255 <==
Modules/binascii.c:1243:42: runtime error: left shift of 129 by 24 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Modules/binascii.c:1243:42

@thesamesam

thesamesam commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

We got there in the end: #111758 (comment) :)

I'd assumed that #135578 or #136820 included that but I didn't check.

thesamesam
thesamesam reviewed Apr 6, 2026
View reviewed changes
Comment thread.github/workflows/reusable-san.yml
thesamesam
thesamesam reviewed Apr 6, 2026
View reviewed changes
Comment thread.github/workflows/reusable-san.yml
@StanFromIreland
StanFromIreland marked this pull request as ready for review April 6, 2026 16:16
@StanFromIreland
StanFromIreland marked this pull request as draft April 6, 2026 16:19
@StanFromIreland
StanFromIreland marked this pull request as ready for review April 6, 2026 17:19
@encukou

encukou commented Apr 9, 2026

Copy link
Copy Markdown
Member

LGTM, thank you!
Consider opening an issue, which we could use to track the fixes too.

@StanFromIrelandStanFromIreland changed the title Fail on new UB in CIgh-148286: Fail on new UB in CIApr 9, 2026
@StanFromIreland

StanFromIreland commented Apr 9, 2026

Copy link
Copy Markdown
MemberAuthor

Created #148286.

@StanFromIreland
StanFromIreland merged commit ade914b into python:mainApr 9, 2026
48 checks passed
@StanFromIreland
StanFromIreland deleted the san-ubsan branch April 9, 2026 09:30
@StanFromIreland

StanFromIreland commented Apr 9, 2026

Copy link
Copy Markdown
MemberAuthor

Thanks for the reviews!

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@StanFromIreland@ljfp
pythongh-148286: Fail when new UB is found by CI UBSan (python#148168)
ebe6d29
@vstinnervstinner mentioned this pull request Jun 10, 2026
Closed
@bedevere-appbedevere-appBot mentioned this pull request Jun 10, 2026
Open
@matthiasgoergensmatthiasgoergens mentioned this pull request Aug 5, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@webknjazwebknjazAwaiting requested review from webknjazwebknjaz is a code owner
@encukouencukouAwaiting requested review from encukou
1 more reviewer
@thesamesamthesamesamthesamesam left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@thesamesam@encukou@vstinner