Skip to content

gh-130472: Use fancycompleter in import completions - #148188

Merged
pablogsal merged 13 commits into
python:mainfrom
tomasr8:colorize-imports
May 5, 2026
Merged

gh-130472: Use fancycompleter in import completions#148188
pablogsal merged 13 commits into
python:mainfrom
tomasr8:colorize-imports

Conversation

@tomasr8

@tomasr8tomasr8 commented Apr 6, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
image

Now that #130473 has been merged, let's use it for import completions as well.
This is my first stab at this. First, I did a bit of refactoring and extracted the getattr and colorize logic from FancyCompleter into reusable functions since I needed those for module completions. I also modified ModuleCompleter to return attribute values in addition to names (for modules, it just returns the sys module as a dummy value, this is just to get the color right). Then I just needed to extend get_module_completions to do the colorization.

@loic-simon would love if you have some spare time to have a look :)

@tomasr8
Extract safe_getattr into a separate function
89dde8f
@tomasr8
Extract colorize methods into reusable functions
2b05c47
@tomasr8
Colorize import completions
8e75eb6
- Make module completer return both names and values (dummy `sys` module
in case of module completions)
- Colorize completions using `colorize_matches` from FancyCompleter
@tomasr8
Add tests
3b20cf3
@tomasr8
Simplify logic
9e9d9d8
@tomasr8
Improve tests
a1576a0
@tomasr8
Restore original test name
7c95992
@bedevere-appbedevere-appBot mentioned this pull request Apr 6, 2026
Closed
loic-simon
loic-simon reviewed Apr 6, 2026
View reviewed changes

@loic-simonloic-simon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Here's a quick first pass, I'll play around with it in local later 😄

Comment threadLib/_pyrepl/_module_completer.py Outdated
Comment threadLib/_pyrepl/_module_completer.py Outdated
Comment threadLib/_pyrepl/readline.py Outdated
Comment threadLib/test/test_pyrepl/test_pyrepl.py
@loic-simon

loic-simon commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Tested in local, all good for me! 🚀

@loic-simonloic-simon mentioned this pull request Apr 12, 2026
Open
@pablogsal

pablogsal commented May 5, 2026

Copy link
Copy Markdown
Member

LGTM Great work @tomasr8 and thanks for the review @loic-simon. I have pushed a commit with some fixed and simplifications so it can make it to tomorrow's deadline!

@pablogsal
pablogsal enabled auto-merge (squash) May 5, 2026 01:11
@pablogsal
pablogsal disabled auto-merge May 5, 2026 01:11
@pablogsal
pablogsal enabled auto-merge (squash) May 5, 2026 01:12
@read-the-docs-community

read-the-docs-communityBot commented May 5, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32535593 | 📁 Comparing 0b29824 against main (2995d45)

🔍 Preview build

147 files changed · ± 145 modified · - 2 deleted

±Modified

-Deleted

@pablogsal
pablogsal merged commit ed99680 into python:mainMay 5, 2026
65 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner
@ambvambvAwaiting requested review from ambvambv is a code owner
+1 more reviewer
@loic-simonloic-simonloic-simon left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomasr8@loic-simon@pablogsal