Uh oh!
There was an error while loading. Please reload this page.
gh-145866: Convert _CALL_METHOD_DESCRIPTOR_NOARGS to leave its inputs on the stack to be cleaned up by _POP_TOP - #148227
Merged
Fidget-Spinner merged 4 commits intoApr 8, 2026
Conversation
Sacul0457
requested review from
Fidget-Spinner, markshannon, savannahostrowski and tomasr8
as code ownersApril 7, 2026 16:35
Fidget-Spinner
commented
Apr 7, 2026
Member
How do you know it's a stack underflow and not the wrong variable being passed? from the test logs, it looks more like the latter. |
ContributorAuthor
Hmm, do we have to update the |
Fidget-Spinner
commented
Apr 8, 2026
Member
Oh right good catch, yes you do! |
Sacul0457
commented
Apr 8, 2026
| } | ||
| c = callable; | ||
| s = args[0]; | ||
| INPUTS_DEAD(); |
ContributorAuthor
There was a problem hiding this comment.
Not sure if we're allowed to use INPUTS_DEAD here because we previously did not call DEAD for cfunc
There was a problem hiding this comment.
cfunc is an inline cache entry, so it doesn't need to be called dead.
Uh oh!
There was an error while loading. Please reload this page.
ljfp pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…s inputs on the stack to be cleaned up by _POP_TOP (pythonGH-148227)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Fidget-Spinner gentle ping :)
This seems to cause a stack underflow, but I am unable to figure out why. So instead of trying with no results, thought I'd just raise a PR instead!
_POP_TOP#145866