Skip to content

gh-131798: optimize through keyword and bound method calls in the JIT - #148466

Merged
Fidget-Spinner merged 7 commits into
python:mainfrom
kumaraditya303:jit-calls
Apr 13, 2026
Merged

gh-131798: optimize through keyword and bound method calls in the JIT#148466
Fidget-Spinner merged 7 commits into
python:mainfrom
kumaraditya303:jit-calls

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Apr 12, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Apr 12, 2026
Open
Fidget-Spinner
Fidget-Spinner reviewed Apr 13, 2026
View reviewed changes
Comment threadPython/optimizer_bytecodes.c
Fidget-Spinner
Fidget-Spinner reviewed Apr 13, 2026
View reviewed changes
Comment threadLib/test/test_capi/test_opt.py Outdated

def test_call_kw(self):
def func(a):
return 42 * a

@Fidget-SpinnerFidget-SpinnerApr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be checking that we optimize through the trace. So the best way is to put a global (e.g. range) here and check if it gets promoted in the tests below. See for example test_init_resolves_callable which does self.assertNotIn("_LOAD_GLOBAL_BUILTINS", uops). Same for the other test.

@Fidget-Spinner

Fidget-Spinner commented Apr 13, 2026

Copy link
Copy Markdown
Member

It's not optimizing through the bound method because we're missing _EXPAND_METHOD_KW in the JIT. I think you can just copy whatever _EXPAND_METHOD has and place it under there.

@Fidget-SpinnerFidget-Spinner changed the title gh-131798: optimize CALL_KW_PY in the JITgh-131798: optimize through keyword and bound method calls in the JITApr 13, 2026
Fidget-Spinner
Fidget-Spinner approved these changes Apr 13, 2026
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should be a pretty decent win.

@Fidget-Spinner
Fidget-Spinner merged commit 88e378c into python:mainApr 13, 2026
78 checks passed
@kumaraditya303
kumaraditya303 deleted the jit-calls branch April 13, 2026 15:11
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@kumaraditya303@Fidget-Spinner@ljfp
pythongh-131798: optimize through keyword and bound method calls in t…
ff5f784
…he JIT (pythonGH-148466)
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

No one assigned

Labels

skip newstopic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumaraditya303@Fidget-Spinner