Skip to content

gh-131798: Add _GET_ITER_TRAD to JIT optimizer - #148724

Closed
Wulian233 wants to merge 1 commit into
python:mainfrom
Wulian233:_GET_ITER_TRAD
Closed

gh-131798: Add _GET_ITER_TRAD to JIT optimizer#148724
Wulian233 wants to merge 1 commit into
python:mainfrom
Wulian233:_GET_ITER_TRAD

Conversation

@Wulian233

@Wulian233Wulian233 commented Apr 18, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Apr 18, 2026
Open
@cocolato

cocolato commented Apr 18, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Thankls for doing this.

cpython/Python/optimizer_bytecodes.c

Line 1429 in 7ce737e

ADD_OP(_GET_ITER_TRAD, 0, 0);

But _GET_ITER_TRAD only be added in the output buffer, so this optimization will never be applied now.

@Wulian233

Wulian233 commented Apr 18, 2026

Copy link
Copy Markdown
ContributorAuthor

Thank you for your explanation. It was my oversight that I didn't notice it. So I turned it close first❤️

@Wulian233
Wulian233 deleted the _GET_ITER_TRAD branch April 18, 2026 19:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

No one assigned

Labels

awaiting reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wulian233@cocolato