Skip to content

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py - #149345

Merged
vstinner merged 9 commits into
python:mainfrom
skirpichev:amend-e-format
May 6, 2026
Merged

gh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.py#149345
vstinner merged 9 commits into
python:mainfrom
skirpichev:amend-e-format

Conversation

@skirpichev

@skirpichevskirpichev commented May 4, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@skirpichev
pythongh-146238: add missing tests for 'e' type code in test_buffer.py
d00c981
This amends e79fd60. I'll not fix this for 'F'/'D' complex types as
they might be removed.
@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label May 4, 2026
@bedevere-appbedevere-appBot mentioned this pull request May 4, 2026
Closed
@skirpichev
skirpichev deleted the amend-e-format branch May 4, 2026 15:25
@skirpichev
skirpichev restored the amend-e-format branch May 5, 2026 02:01
@skirpichevskirpichev reopened this May 5, 2026
@skirpichevskirpichev changed the title gh-146238: add missing tests for 'e' type code in test_buffer.pygh-146238: add missing tests for 'e', 'Zf' and 'Zd' array type codes in test_buffer.pyMay 5, 2026
@skirpichev
skirpichev requested a review from vstinnerMay 5, 2026 02:27
@skirpichev

skirpichev commented May 5, 2026

Copy link
Copy Markdown
MemberAuthor

CC @vstinner

@skirpichev

This comment was marked as resolved.

Sign in to view
@read-the-docs-community

This comment was marked as spam.

Sign in to view
vstinner
vstinner reviewed May 5, 2026
View reviewed changes
Comment threadLib/test/test_buffer.py Outdated
Comment threadLib/test/test_buffer.py Outdated
Comment threadLib/test/test_buffer.py
@vstinner

This comment was marked as resolved.

Sign in to view
@vstinner

vstinner commented May 5, 2026

Copy link
Copy Markdown
Member

On WASI, ALIGNOF_MAX_ALIGN_T is 16 bytes and struct.calcsize("Zd") is 16 bytes. WASI is a 32-bit platform (sys.maxsize is 2147483647). Maybe we should only test formats up to 4 bytes?

Would it make sense to use MAX_ALIGN = struct.calcsize('P')?

@skirpichev

skirpichev commented May 6, 2026

Copy link
Copy Markdown
MemberAuthor

Would it make sense to use MAX_ALIGN = struct.calcsize('P')?

As you see from the commit history, just removing the 'Zd' type - works. But I would like to use a more generic solution.

@vstinner
vstinner merged commit ffa4d47 into python:mainMay 6, 2026
49 checks passed
@vstinner

vstinner commented May 6, 2026

Copy link
Copy Markdown
Member

I prefer a small performance hit for readability.

I would prefer to not build list("bBhHiIlLefd") + ['Zf', 'Zd'] list at each NATIVE iteration, but it's not a big deal. I merged your PR. Thanks for additional tests.

@skirpichev
skirpichev deleted the amend-e-format branch May 6, 2026 13:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev@vstinner