Skip to content

gh-149358: Generating JIT recorder transformers and stabilizing family layouts - #149359

Merged
markshannon merged 8 commits into
python:mainfrom
cocolato:jit_record_family
May 21, 2026
Merged

gh-149358: Generating JIT recorder transformers and stabilizing family layouts#149359
markshannon merged 8 commits into
python:mainfrom
cocolato:jit_record_family

Conversation

@cocolato

@cocolatococolato commented May 4, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 4, 2026
Closed
@read-the-docs-community

read-the-docs-communityBot commented May 4, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32525708 | 📁 Comparing 5617cec against main (2ba0a81)

🔍 Preview build

3 files changed
±library/calendar.html
±whatsnew/3.15.html
±whatsnew/changelog.html

@cocolatococolato mentioned this pull request May 4, 2026
Merged
markshannon
markshannon requested changes May 19, 2026
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with a couple more tests, but looks good otherwise

Comment threadLib/test/test_generated_cases.py
op(_DO_STUFF, (tos -- res)) {
res = tos;
}
macro(OP) = _RECORD_TOS + _DO_STUFF;

@markshannonmarkshannonMay 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for:

  • Base op does not record, but specialization does
  • Base op does record, but specialization does not

Comment threadTools/cases_generator/analyzer.py Outdated
size: str
members: list[Instruction]

@property

@markshannonmarkshannonMay 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a normal function? It is quite heavyweight for a property

@bedevere-app

bedevere-appBot commented May 19, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cocolato

cocolato commented May 20, 2026

Copy link
Copy Markdown
MemberAuthor

Thanks for review ! I have made the requested changes; please review again.

@bedevere-app

bedevere-appBot commented May 20, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app
bedevere-appBot requested a review from markshannonMay 20, 2026 10:09
markshannon
markshannon approved these changes May 21, 2026
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@markshannon
markshannon merged commit 0828782 into python:mainMay 21, 2026
84 of 87 checks passed
@cocolato
cocolato deleted the jit_record_family branch May 23, 2026 09:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cocolato@markshannon