Skip to content

gh-149321: Remove lazy_imports=none startup mode - #149389

Merged
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-149321-remove-lazy-imports-none
May 19, 2026
Merged

gh-149321: Remove lazy_imports=none startup mode#149389
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-149321-remove-lazy-imports-none

Conversation

@pablogsal

@pablogsalpablogsal commented May 5, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 5, 2026
Closed
@read-the-docs-community

read-the-docs-communityBot commented May 5, 2026•
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32766631 | 📁 Comparing f406e17 against main (f025dba)

🔍 Preview build

92 files changed · + 3 added · ± 89 modified

+Added

±Modified

@pablogsal
pablogsalforce-pushed the gh-149321-remove-lazy-imports-none branch from 6fe086b to 91fd216CompareMay 5, 2026 00:44
@hugovk

hugovk commented May 5, 2026

Copy link
Copy Markdown
Member

Docs fail:

ERROR: Removed IDs found
c-api/import.html: c.PyImport_LazyImportsMode.PyImport_LAZY_NONE
The above HTML IDs were removed from the documentation, resulting in broken links. Please add them back.
Alternatively, add them to Doc/tools/removed-ids.txt.

In this case, we can add them to Doc/tools/removed-ids.txt.

StanFromIreland
StanFromIreland reviewed May 5, 2026
View reviewed changes
Comment threadDoc/tools/removed-ids.txt
@brettcannon
brettcannon removed their request for review May 5, 2026 17:38
@hugovk

hugovk commented May 6, 2026

Copy link
Copy Markdown
Member

I resolved the conflict and added the section comment to Doc/tools/removed-ids.txt.

ZeroIntensity
ZeroIntensity approved these changes May 18, 2026
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
pablogsalforce-pushed the gh-149321-remove-lazy-imports-none branch from a4e1b26 to 4fb4be1CompareMay 19, 2026 21:05
@pablogsal
pablogsal merged commit 1f3c267 into python:mainMay 19, 2026
60 checks passed
@pablogsal
pablogsal deleted the gh-149321-remove-lazy-imports-none branch May 19, 2026 23:01
@pablogsalpablogsal added awaiting merge needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 19, 2026
@miss-islington-app

miss-islington-appBot commented May 19, 2026

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented May 19, 2026

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1f3c2679f1a2a106019ceedc7a61c278a445c264 3.15

@bedevere-app

bedevere-appBot commented May 19, 2026

Copy link
Copy Markdown

GH-150129 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 19, 2026
@jbosboom

jbosboom commented May 19, 2026

Copy link
Copy Markdown
Contributor

I haven't followed this issue at all, but the huge number of lines added jumped out at me from the repo front page. Was adding Python/deepfreeze/deepfreeze.c a mistake?

@ZeroIntensity

ZeroIntensity commented May 20, 2026

Copy link
Copy Markdown
Member

Yeah, that looks like a mistake. We should revert that part @pablogsal

pablogsal added a commit to pablogsal/cpython that referenced this pull request Jun 8, 2026
@pablogsal
[3.15]pythongh-149321: Remove lazy_imports=none startup mode (python…
7590438
…GH-149389)
(cherry picked from commit 1f3c267)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jun 8, 2026
@pablogsal
[3.15]pythongh-149321: Remove lazy_imports=none startup mode (python…
48575f6
…GH-149389)
(cherry picked from commit 1f3c267)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 8, 2026
@pablogsal
[3.15]gh-149321: Remove lazy_imports=none startup mode (GH-149389) (#…
83e26a4
…150129)
@jbosboom

jbosboom commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The mistakenly added Python/deepfreeze/deepfreeze.c was removed in #150192.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@ZeroIntensityZeroIntensityZeroIntensity approved these changes
@Yhg1sYhg1sAwaiting requested review from Yhg1sYhg1s is a code owner
@DinoVDinoVAwaiting requested review from DinoVDinoV is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@hugovkhugovkAwaiting requested review from hugovk

Assignees

@pablogsalpablogsal

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal@hugovk@jbosboom@ZeroIntensity@StanFromIreland@encukou