Skip to content

move Codecov configuration under .github - #1494

Merged
brettcannon merged 3 commits into
python:masterfrom
morrme:fix-80
May 13, 2017
Merged

move Codecov configuration under .github#1494
brettcannon merged 3 commits into
python:masterfrom
morrme:fix-80

Conversation

@morrme

@morrmemorrme commented May 7, 2017

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented May 7, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@brettcannon

brettcannon commented May 8, 2017

Copy link
Copy Markdown
Member

Could you also drop the leading . from the name? That way it matches appveyor.yml.

@brettcannonbrettcannon self-assigned this May 8, 2017
@brettcannon

brettcannon commented May 8, 2017

Copy link
Copy Markdown
Member

While this doesn't really require signing the CLA, @morrme , it would be great if you could for future contributions. 😄

@morrme

morrme commented May 12, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@brettcannon will do! waiting for that process to complete shouldn't delay this PR, right?

@brettcannon

brettcannon commented May 13, 2017

Copy link
Copy Markdown
Member

@morrme nope, the hold-up is on me just simply being busy with the run-up to PyCon US.

@morrme

morrme commented May 13, 2017

Copy link
Copy Markdown
ContributorAuthor

@brettcannon oh, cool..... just wanted to make sure i wasn't delaying things. enjoy PyCon! I wish I could be there!

@brettcannon
brettcannon merged commit cbddf58 into python:masterMay 13, 2017
brettcannon pushed a commit to brettcannon/cpython that referenced this pull request May 13, 2017
@morrme@brettcannon
[3.6] Move Codecov's configuration file under .github (pythonGH-1494)
15d2fbc
(cherry picked from commit cbddf58)
brettcannon pushed a commit to brettcannon/cpython that referenced this pull request May 13, 2017
@morrme@brettcannon
[3.5] Move Codecov's configuration file under .github (pythonGH-1494)
595aa59
(cherry picked from commit cbddf58)
brettcannon added a commit that referenced this pull request May 13, 2017
@brettcannon
[3.6] Move Codecov's configuration file under .github (GH-1494) (GH-1574
178756c
)
(cherry picked from commit cbddf58)
brettcannon added a commit that referenced this pull request May 13, 2017
@brettcannon
[3.5] Move Codecov's configuration file under .github (GH-1494) (#1575)
9b7fe99
(cherry picked from commit cbddf58)
@brettcannon

brettcannon commented May 13, 2017

Copy link
Copy Markdown
Member

Thanks for the PR, @morrme !

@hugovkhugovk mentioned this pull request Feb 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

Assignees

@brettcannonbrettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move Codecov configuration under .github

4 participants

@morrme@the-knights-who-say-ni@brettcannon@Mariatta