Uh oh!
There was an error while loading. Please reload this page.
Rewrite RTD configuration to use build.jobs rather than build.commands - #149429
Conversation
dfcae69 to
7438633Compare| then | ||
| base_branch=main; | ||
| git fetch --depth=50 origin $base_branch; | ||
| for attempt in $(seq 10); |
There was a problem hiding this comment.
I think @StanFromIreland added a bash script for progressive unshallowing some time ago based on my experiments elsewhere. We could probably reuse that.
There was a problem hiding this comment.
Oh, he embedded bash in YAML: #147975 (comment). But perhaps, if it's extracted into Tools/, we could deduplicate the logic.
There was a problem hiding this comment.
Deduplicating sounds good, but I think I'll leave that for a later cleanup.
Uh oh!
There was an error while loading. Please reload this page.
…commands --no-stat on merge
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
GH-149432 is a backport of this pull request to the 3.14 branch. |
zware
commented
May 5, 2026
Opened the backport ahead of time because it needs to be manually adjusted anyway, and I want to make sure it doesn't do anything too weird on the 3.14 branch. |
… build.commands (pythonGH-149429) --set-upstream on initial fetch
… build.commands (pythonGH-149429) no --set-upstream, add explicit origin/?
| set -eEux; | ||
| if [ "$READTHEDOCS_VERSION_TYPE" = "external" ]; | ||
| then | ||
| base_branch=main; |
There was a problem hiding this comment.
Is there an env var that could be used instead of main? I imagine this isn't going to work well in backport PRs unless we check against stable branches.
There was a problem hiding this comment.
My plan is to manually set base_branch to the right branch in each backport; I'm afraid RTD doesn't provide the base branch anywhere (that's documented, anyway).
There was a problem hiding this comment.
Alright, that works as a workaround. Though, I'd rather have RTD fix it.
curl -s https://api.github.com/repos/python/cpython/pulls/149429 | jq --raw-output '.base.ref' will get you what you want unless they rate-limit you (which is likely).
GHA provides a GITHUB_EVENT_PATH env var with a file path to the entire webhook payload. RTD should do the same so that people wouldn't have to ask them to expose every single bit that GH sends them w/o additional API requests one by one.
There was a problem hiding this comment.
Oh I just saw this discussion, I wrote #150690 with it.
webknjaz
left a comment
There was a problem hiding this comment.
I think this can be merged, keeping in mind possible follow-up improvements in the future.
…commands Add explicit local branch name needed in backports
Documentation build overview
|
…commands Avoid "refname 'origin/main' is ambiguous" warnings
Uh oh!
There was an error while loading. Please reload this page.
…commands Missed these...
… build.commands (pythonGH-149429) Fixups from `main`
Uh oh!
There was an error while loading. Please reload this page.
No description provided.