Skip to content

gh-149879: Don't import msvcrt in _pyio on Cygwin - #149899

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pyio
May 15, 2026
Merged

gh-149879: Don't import msvcrt in _pyio on Cygwin#149899
vstinner merged 1 commit into
python:mainfrom
vstinner:pyio

Conversation

@vstinner

@vstinnervstinner commented May 15, 2026

Copy link
Copy Markdown
Member

The msvcrt extension module cannot be built on Cygwin.

The msvcrt extension module cannot be built on Cygwin.
@vstinner

Copy link
Copy Markdown
MemberAuthor

This change fix a regression introduced by commit f0f55a0 in 2015. It does fix the issue reported in 2016: #69069 (comment).

@vstinner

Copy link
Copy Markdown
MemberAuthor

The macos-26 job failed with:

FAIL: test_trampoline_works_with_forks (test.test_perf_profiler.TestPerfTrampoline.test_trampoline_works_with_forks)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/runner/work/cpython/cpython/Lib/test/test_perf_profiler.py", line 145, in test_trampoline_works_with_forks
self.assertEqual(process.returncode, 0)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 11 != 0

That's the unrelated issue gh-149156.

@vstinner
vstinner merged commit 1441f2f into python:mainMay 15, 2026
93 of 95 checks passed
@vstinner
vstinner deleted the pyio branch May 15, 2026 21:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner