Skip to content

gh-149931: Fix memory leaks on failed realloc - #149932

Merged
pablogsal merged 3 commits into
python:mainfrom
aisk:leak-on-realloc
May 26, 2026
Merged

gh-149931: Fix memory leaks on failed realloc#149932
pablogsal merged 3 commits into
python:mainfrom
aisk:leak-on-realloc

Conversation

@aisk

@aiskaisk commented May 17, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 17, 2026
Closed
@aisk

aisk commented May 17, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

The changes in Modules/_remote_debugging/frames.c are in a different file in 3.13 branch. 3.13 support will ended in a few months, so I think it's OK to don't backport to it?

@aiskaisk added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 17, 2026
StanFromIreland
StanFromIreland reviewed May 17, 2026
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2026-05-17-14-58-21.gh-issue-149931.9Oh2go.rst Outdated
MojoVampire
MojoVampire reviewed May 18, 2026
View reviewed changes
Comment threadModules/timemodule.c
@pablogsal

pablogsal commented May 26, 2026

Copy link
Copy Markdown
Member

LGTM Great job!

@pablogsal
pablogsal merged commit ec23ec6 into python:mainMay 26, 2026
52 checks passed
@miss-islington-app

miss-islington-appBot commented May 26, 2026

Copy link
Copy Markdown

Thanks @aisk for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented May 26, 2026

Copy link
Copy Markdown

Sorry, @aisk and @pablogsal, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ec23ec6870373b64a760f4d7bcc3ed5495e1c9aa 3.14

@bedevere-app

bedevere-appBot commented May 26, 2026

Copy link
Copy Markdown

GH-150439 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 26, 2026
@pablogsal

pablogsal commented May 26, 2026

Copy link
Copy Markdown
Member

@aisk can you take care of the backports following the bot instructions?

pablogsal pushed a commit that referenced this pull request May 26, 2026
@miss-islington
[3.15]gh-149931: Fix memory leaks on failed realloc (GH-149932) (#15…
d73e433
…0439)
@aisk
aisk deleted the leak-on-realloc branch May 26, 2026 01:23
@bedevere-app

bedevere-appBot commented May 26, 2026

Copy link
Copy Markdown

GH-150476 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MojoVampireMojoVampireMojoVampire left review comments
@pablogsalpablogsalpablogsal approved these changes
@StanFromIrelandStanFromIrelandStanFromIreland approved these changes
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

Assignees

@pablogsalpablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aisk@pablogsal@MojoVampire@StanFromIreland