Skip to content

gh-145306: Fix browser open after empty export - #150017

Merged
pablogsal merged 2 commits into
python:mainfrom
lkollar:tachyon/fix-browser-open
Jun 27, 2026
Merged

gh-145306: Fix browser open after empty export#150017
pablogsal merged 2 commits into
python:mainfrom
lkollar:tachyon/fix-browser-open

Conversation

@ivonastojanovic

@ivonastojanovicivonastojanovic commented May 18, 2026

Copy link
Copy Markdown
Contributor

Make sampling exporters report whether output was generated, and only open HTML reports in the browser after a successful export.

@bedevere-appbedevere-appBot mentioned this pull request May 18, 2026
Open
maurycy
maurycy reviewed May 19, 2026
View reviewed changes
Comment threadLib/profiling/sampling/cli.py Outdated
@picnixzpicnixz changed the title gh-145306 Fix browser open after empty exportgh-145306: Fix browser open after empty exportMay 19, 2026
lkollar added 2 commits May 21, 2026 16:49
@lkollar
Fix browser open after empty export
7124c94
Make sampling exporters report whether output was generated, and only
open HTML reports in the browser after a successful export.
@lkollar
fixup! Fix browser open after empty export
4334b0f
@lkollar
lkollarforce-pushed the tachyon/fix-browser-open branch from e98a58b to 4334b0fCompareMay 21, 2026 15:51
@lkollarlkollar mentioned this pull request May 30, 2026
Closed
@pablogsal
pablogsal merged commit 860f8a5 into python:mainJun 27, 2026
53 checks passed
@pablogsalpablogsal added awaiting merge needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 27, 2026
@miss-islington-app

miss-islington-appBot commented Jun 27, 2026

Copy link
Copy Markdown

Thanks @ivonastojanovic for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jun 27, 2026

Copy link
Copy Markdown

GH-152447 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 27, 2026
pablogsal pushed a commit that referenced this pull request Jun 27, 2026
@miss-islington@ivonastojanovic
[3.15]gh-145306: Fix browser open after empty export (GH-150017) (#1…
5d0fa7a
…52447)
gh-145306: Fix browser open after empty export (GH-150017)
(cherry picked from commit 860f8a5)
Co-authored-by: ivonastojanovic <80911834+ivonastojanovic@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes
+1 more reviewer
@maurycymaurycymaurycy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting mergeskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivonastojanovic@maurycy@pablogsal@lkollar