Skip to content

gh-150069: Test frozen dataclass and properties interaction - #150070

Merged
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-150069
Jul 2, 2026
Merged

gh-150069: Test frozen dataclass and properties interaction#150070
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-150069

Conversation

@sobolevn

@sobolevnsobolevn commented May 19, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Since #144021 was backported to 3.13, I also mark my PR with the same backports.

@sobolevn
sobolevn requested a review from carljmMay 19, 2026 09:49
@sobolevn
sobolevn requested a review from ericvsmith as a code ownerMay 19, 2026 09:49
@bedevere-appbedevere-appBot mentioned this pull request May 19, 2026
Closed
@sobolevnsobolevn added skip news needs backport to 3.15 pre-release feature fixes, bugs and security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 19, 2026
@sobolevn

sobolevn commented Jun 10, 2026

Copy link
Copy Markdown
MemberAuthor

@carljm@ericvsmith friendly ping 👋

carljm
carljm approved these changes Jun 10, 2026
View reviewed changes

@carljmcarljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, comments are nits.

Comment threadLib/test/test_dataclasses/__init__.py
Comment threadLib/test/test_dataclasses/__init__.py Outdated
Comment threadLib/test/test_dataclasses/__init__.py Outdated
Comment threadLib/test/test_dataclasses/__init__.py
with self.assertRaises(FrozenInstanceError):
d.i = 5

def test_non_frozen_normal_derived(self):

@carljmcarljmJun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is now quite large and checking quite a few only loosely related behaviors. Not a blocker but might be ideal to break it up.

@sobolevnsobolevnJul 2, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I don't see a clean way to do that :(
It is rather big, but pretty clear. So, I decided to keep it as-is :)

@sobolevn

sobolevn commented Jul 2, 2026

Copy link
Copy Markdown
MemberAuthor

@carljm thanks a lot for your feedback, I updated my test with your suggestions and scheduled it to be merged :)

@sobolevn
sobolevn enabled auto-merge (squash) July 2, 2026 12:20
@sobolevn
sobolevn merged commit 753f82d into python:mainJul 2, 2026
48 checks passed
@miss-islington-app

miss-islington-appBot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jul 2, 2026

Copy link
Copy Markdown

GH-152882 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 2, 2026
@miss-islington-app

miss-islington-appBot commented Jul 2, 2026

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 753f82db2fed38bf725ded2b333ea3749c81fe82 3.13

@bedevere-app

bedevere-appBot commented Jul 2, 2026

Copy link
Copy Markdown

GH-152883 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 2, 2026
@bedevere-app

bedevere-appBot commented Jul 2, 2026

Copy link
Copy Markdown

GH-152887 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 2, 2026
sobolevn added a commit that referenced this pull request Jul 2, 2026
@miss-islington@sobolevn
[3.14]gh-150069: Test frozen dataclass and properties interaction (G…
f86e295
…H-150070) (#152883)
gh-150069: Test frozen dataclass and properties interaction (GH-150070)
(cherry picked from commit 753f82d)
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 2, 2026
@miss-islington@sobolevn
[3.15]gh-150069: Test frozen dataclass and properties interaction (G…
d8493ae
…H-150070) (#152882)
gh-150069: Test frozen dataclass and properties interaction (GH-150070)
(cherry picked from commit 753f82d)
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 2, 2026
@sobolevn
[3.13]gh-150069: Test frozen dataclass and properties interaction (G…
a1cb073
…H-150070) (#152887)
(cherry picked from commit 753f82d)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes
@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith is a code owner

Assignees

@sobolevnsobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@carljm