Skip to content

gh-150178: Fix refcount leaks in hamt allocation failure paths - #150179

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
lpyu001:hamt
May 23, 2026
Merged

gh-150178: Fix refcount leaks in hamt allocation failure paths#150179
kumaraditya303 merged 2 commits into
python:mainfrom
lpyu001:hamt

Conversation

@lpyu001

@lpyu001lpyu001 commented May 21, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@lpyu001
lpyu001 requested a review from 1st1 as a code ownerMay 21, 2026 08:04
@bedevere-appbedevere-appBot mentioned this pull request May 21, 2026
Closed
@picnixzpicnixz changed the title gh-150178:Fix refcount leaks in hamt allocation failure pathsgh-150178: Fix refcount leaks in hamt allocation failure pathsMay 21, 2026
@aisk

aisk commented May 21, 2026

Copy link
Copy Markdown
Member

The fix looks good to me. However, I think the NEWS entry is too internal-facing, and it's a rare-case fix, so I don't think we need a NEWS entry for it.

@lpyu001

lpyu001 commented May 21, 2026

Copy link
Copy Markdown
ContributorAuthor

The fix looks good to me. However, I think the NEWS entry is too internal-facing, and it's a rare-case fix, so I don't think we need a NEWS entry for it.

thanks for your comments, I've delete NEWS

@kumaraditya303
kumaraditya303 merged commit 32823af into python:mainMay 23, 2026
60 checks passed
@kumaraditya303kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 23, 2026
@miss-islington-app

miss-islington-appBot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented May 23, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented May 23, 2026

Copy link
Copy Markdown

GH-150301 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 23, 2026
kumaraditya303 pushed a commit that referenced this pull request May 23, 2026
@miss-islington@lpyu001
[3.13]gh-150178: Fix refcount leaks in hamt allocation failure paths (…
95c9323
…GH-150179) (#150301)
gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)
Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
kumaraditya303 pushed a commit that referenced this pull request May 23, 2026
@miss-islington@lpyu001
[3.15]gh-150178: Fix refcount leaks in hamt allocation failure paths (…
6b17d1a
…GH-150179) (#150303)
gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)
Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
kumaraditya303 pushed a commit that referenced this pull request May 24, 2026
@miss-islington@lpyu001
[3.14]gh-150178: Fix refcount leaks in hamt allocation failure paths (…
5676bfc
…GH-150179) (#150302)
gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179)
(cherry picked from commit 32823af)
Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
@StanFromIrelandStanFromIreland mentioned this pull request Jul 3, 2026
Open
@StanFromIrelandStanFromIreland removed the needs backport to 3.14 bugs and security fixes label Jul 3, 2026
@StanFromIrelandStanFromIreland removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 3, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aiskaiskaisk approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lpyu001@aisk@kumaraditya303@StanFromIreland