Uh oh!
There was an error while loading. Please reload this page.
gh-85989: move HAVE_DOUBLE_ROUNDING check to test.support - #150219
Merged
Conversation
skirpichev
commented
May 26, 2026
MemberAuthor
CC @vstinner |
Uh oh!
There was an error while loading. Please reload this page.
vstinner
approved these changes
May 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
May 26, 2026
Member
I merged #150432. It created conflicts. Can you please update your PR to solve conflicts? |
Co-authored-by: Victor Stinner <vstinner@python.org>
skirpichev
commented
May 26, 2026
MemberAuthor
Done. |
| HAVE_DOUBLE_ROUNDING = (x + y == 1e16 + 4) | ||
| skip_if_double_rounding = unittest.skipIf(HAVE_DOUBLE_ROUNDING, | ||
| "accuracy not guaranteed on " | ||
| "machines with double rounding") |
Member
There was a problem hiding this comment.
Since all tests use @skip_if_double_rounding, I don't think that it's useful to expose HAVE_DOUBLE_ROUNDING variable. I suggest removing unused variables:
del x, y, HAVE_DOUBLE_ROUNDING
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
May 28, 2026
Member
Merged, thanks for the change. It's good to share code between tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds skip_if_double_rounding decorator.