Skip to content

gh-115119: Fix libmpdec detection when pkg-config files are missing#150502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Jun 2, 2026
Merged

gh-115119: Fix libmpdec detection when pkg-config files are missing #150502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f508b78
gh-115119: Fix libmpdec detection when pkg-config files are missing
stratakis May 27, 2026
7430986
Add news entry
stratakis May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2026-05-27-14-28-36.gh-issue-115119.wotFWh.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
Fix the detection of libmpdec header when no .pc files are available.
156 changes: 138 additions & 18 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 13 additions & 10 deletions configure.ac
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4380,16 +4380,19 @@ PKG_CHECK_MODULES([LIBMPDEC], [libmpdec >= 2.5.0], [have_mpdec=yes], [
WITH_SAVE_ENV([
CPPFLAGS="$CPPFLAGS $LIBMPDEC_CFLAGS"
LIBS="$LIBS $LIBMPDEC_LIBS"

AC_LINK_IFELSE([
AC_LANG_PROGRAM([
#include <mpdecimal.h>
#if MPD_VERSION_HEX < 0x02050000
# error "mpdecimal 2.5.0 or higher required"
#endif
], [const char *x = mpd_version();])],
[have_mpdec=yes],
[have_mpdec=no])
AC_CHECK_HEADER([mpdecimal.h], [

@vstinnervstinnerJun 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC_CHECK_HEADER([mpdecimal.h] seems to be redundant to me. Is it really useful? We already check we can build/link a C program which starts with #include <mpdecimal.h> (below).

@stratakisstratakisJun 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to have it there for the helpful error message, referencing that the header is missing aka "checking for mpdecimal.h... no". In the case the library is there without the header it will move on to compile the program with "checking for mpd_version in -lmpdec... yes" and then fail.

@skirpichevskirpichevJun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. These checks are logically distinct: first is for the header, next is for the library version.

AC_CHECK_LIB([mpdec], [mpd_version], [
AC_COMPILE_IFELSE([
AC_LANG_PROGRAM([
#include <mpdecimal.h>
#if MPD_VERSION_HEX < 0x02050000
# error "mpdecimal 2.5.0 or higher required"
#endif
], [])],
[have_mpdec=yes],
[have_mpdec=no])
], [have_mpdec=no])
], [have_mpdec=no])

AS_VAR_IF([have_mpdec], [yes], [
LIBMPDEC_CFLAGS=${LIBMPDEC_CFLAGS-""}
Expand Down
Loading