Skip to content

gh-144774: Add critical section in BaseException.__setstate__ - #150578

Merged
kumaraditya303 merged 9 commits into
python:mainfrom
brijkapadia:exception-data-race
May 30, 2026
Merged

gh-144774: Add critical section in BaseException.__setstate__#150578
kumaraditya303 merged 9 commits into
python:mainfrom
brijkapadia:exception-data-race

Conversation

@brijkapadia

@brijkapadiabrijkapadia commented May 29, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Adds a critical section to prevent a data race in exceptions.c.
Unsure if the test is in the right location.
I don't think that a news entry is necessary.

@bedevere-appbedevere-appBot mentioned this pull request May 29, 2026
Closed
kumaraditya303
kumaraditya303 reviewed May 29, 2026
View reviewed changes
Comment threadObjects/exceptions.c Outdated
colesbury
colesbury reviewed May 29, 2026
View reviewed changes
Comment threadObjects/exceptions.c Outdated
@picnixzpicnixz changed the title gh-144774: Add critical section in exceptions.c with PyDict_Nextgh-144774: Add critical section in BaseException.__setstate__May 29, 2026
@picnixz

picnixz commented May 29, 2026

Copy link
Copy Markdown
Member

I don't think that a news entry is necessary.

Usually a bug fix always includes a NEWS entry, at least to indicate that a crash has been fixed. In this case, it's a data race that has been fixed when an exception is being copied while being mutated.

@brijkapadia@colesbury
Update Objects/exceptions.c
4972586
Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury
colesbury reviewed May 29, 2026
View reviewed changes
Comment threadLib/test/test_exceptions.py Outdated
colesbury
colesbury reviewed May 29, 2026
View reviewed changes
Comment threadLib/test/test_exceptions.py Outdated
brijkapadia
brijkapadia commented May 29, 2026
View reviewed changes
Comment threadLib/test/test_exceptions.py
@kumaraditya303

kumaraditya303 commented May 30, 2026

Copy link
Copy Markdown
Contributor

You need to do make regen-clinic again.

@kumaraditya303
kumaraditya303 merged commit f586fd9 into python:mainMay 30, 2026
55 checks passed
@brijkapadia
brijkapadia deleted the exception-data-race branch May 30, 2026 15:57
@naschemenascheme mentioned this pull request Jul 14, 2026
Closed
@kumaraditya303kumaraditya303 added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 15, 2026
@miss-islington-app

miss-islington-appBot commented Jul 15, 2026

Copy link
Copy Markdown

Thanks @brijkapadia for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jul 15, 2026

Copy link
Copy Markdown

GH-153746 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 15, 2026
kumaraditya303 pushed a commit that referenced this pull request Jul 15, 2026
@miss-islington@brijkapadia
[3.15]gh-144774: Add critical section inBaseException.__setstate__(
25eb043
GH-150578) (#153746)
gh-144774: Add critical section in `BaseException.__setstate__` (GH-150578)
(cherry picked from commit f586fd9)
Co-authored-by: Brij Kapadia <97006829+brijkapadia@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jul 16, 2026

Copy link
Copy Markdown

GH-153819 is a backport of this pull request to the 3.14 branch.

nascheme added a commit that referenced this pull request Jul 17, 2026
@nascheme@brijkapadia
[3.14]gh-144774: Add critical section inBaseException.__setstate__(
9a8d756
GH-150578) (GH-153819)
(cherry picked from commit f586fd9)
Co-authored-by: Brij Kapadia <97006829+brijkapadia@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury left review comments
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brijkapadia@picnixz@kumaraditya303@colesbury