Skip to content

GH-150605: use windows-2025 in GitHub Actions - #150606

Merged
chris-eibl merged 3 commits into
python:mainfrom
chris-eibl:workflows_windows-2025
Jun 22, 2026
Merged

GH-150605: use windows-2025 in GitHub Actions#150606
chris-eibl merged 3 commits into
python:mainfrom
chris-eibl:workflows_windows-2025

Conversation

@chris-eibl

@chris-eiblchris-eibl commented May 30, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Marking as draft until we really want to switch in mid-June.

@bedevere-appbedevere-appBot mentioned this pull request May 30, 2026
Closed
@chris-eiblchris-eibl self-assigned this May 30, 2026
@chris-eibl

chris-eibl commented Jun 21, 2026

Copy link
Copy Markdown
MemberAuthor

windows-2025will use Windows Server 2025 with Visual Studio 2026 image in June 2026:

This change will be rolled out over a week beginning June 8, 2026 and will complete by June 15, 2026.

We're now almost a week past 15th, so pulling in main to try out ...

@chris-eibl
chris-eibl marked this pull request as ready for review June 21, 2026 19:13
@webknjaz

webknjaz commented Jun 21, 2026

Copy link
Copy Markdown
Member

Could you explain the motivation? Are they sunsetting this runner label? If not, I don't see why what we have now needs to change.

@chris-eibl

chris-eibl commented Jun 21, 2026

Copy link
Copy Markdown
MemberAuthor

See the links given in the issue. I don't know whether the label windows-2025-vs2026 will ever be sunset, though.

If it stays, then this PR can be closed ofc ...

@chris-eibl

chris-eibl commented Jun 21, 2026

Copy link
Copy Markdown
MemberAuthor

windows-2025-vs2026 was a preview, if it is now official and kept forever, we can keep it.

hugovk
hugovk approved these changes Jun 22, 2026
View reviewed changes

@hugovkhugovk left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The announcement made it clear the old windows-2025-vs2026 label is for testing only:

Note: This label is meant for testing only. After the migration, this label will point to the windows-2025 image.

It may or may not go away, but let's use windows-2025 instead of the testing-only windows-2025-vs2026.

@hugovkhugovk added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 22, 2026
@chris-eibl
chris-eibl enabled auto-merge (squash) June 22, 2026 19:51
@chris-eibl
chris-eibl merged commit b1c4bda into python:mainJun 22, 2026
69 checks passed
@miss-islington-app

miss-islington-appBot commented Jun 22, 2026

Copy link
Copy Markdown

Thanks @chris-eibl for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jun 22, 2026

Copy link
Copy Markdown

GH-151939 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 22, 2026
@chris-eibl
chris-eibl deleted the workflows_windows-2025 branch June 22, 2026 20:25
@webknjaz

webknjaz commented Jun 23, 2026

Copy link
Copy Markdown
Member

Alright, then. Though, I'd prefer the specific label if it's kept since it is clearer about the runtime and is probably more likely to be immutable.

hugovk pushed a commit that referenced this pull request Jun 24, 2026
@miss-islington@chris-eibl
[3.15]GH-150605: use windows-2025 in GitHub Actions (GH-150606) (#15…
1ba0d6e
…1939)
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
pyctrl pushed a commit to pyctrl/cpython that referenced this pull request Jul 5, 2026
@chris-eibl@pyctrl
pythonGH-150605: use windows-2025 in GitHub Actions (python#150606)
9d2fe97
use windows-2025 in GitHub Actions
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@webknjazwebknjazAwaiting requested review from webknjazwebknjaz is a code owner
@itamaroitamaroAwaiting requested review from itamaroitamaro is a code owner

Assignees

@chris-eiblchris-eibl

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chris-eibl@webknjaz@hugovk@muntianus