Skip to content

gh-142889: Improve layout of dictionary keys - #150640

Open
brijkapadia wants to merge 13 commits into
python:mainfrom
brijkapadia:dict-keys
Open

gh-142889: Improve layout of dictionary keys#150640
brijkapadia wants to merge 13 commits into
python:mainfrom
brijkapadia:dict-keys

Conversation

@brijkapadia

@brijkapadiabrijkapadia commented May 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This is based on the work of @clintonsteiner in PR #145097. Most of it is very similar although I did make my own changes.

This PR updates the memory layout of _dictkeysobject to improve performance.

@bedevere-appbedevere-appBot mentioned this pull request May 30, 2026
Open
@brijkapadia
brijkapadia marked this pull request as draft May 30, 2026 22:01
@brijkapadia
brijkapadia marked this pull request as ready for review May 31, 2026 12:15
@markshannon

markshannon commented Jun 2, 2026

Copy link
Copy Markdown
Member

Have you asked @clintonsteiner if it is OK for you to take over their work?

@brijkapadia

brijkapadia commented Jun 2, 2026

Copy link
Copy Markdown
ContributorAuthor

@markshannon No, I didn't. I thought it would be okay to create a new PR since the head repo of #145097 was deleted a month ago. However, I can close this if you think this is unfair.

@clintonsteiner Do you want to continue this?

eendebakpt
eendebakpt reviewed Jun 19, 2026
View reviewed changes
Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated
Comment threadObjects/dictobject.c Outdated
@brijkapadia

brijkapadia commented Jul 23, 2026

Copy link
Copy Markdown
ContributorAuthor

@markshannon, a reminder about this pr, whenever you get a chance.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpteendebakpteendebakpt left review comments
@methanemethaneAwaiting requested review from methanemethane is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner
@itamaroitamaroAwaiting requested review from itamaroitamaro is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brijkapadia@markshannon@eendebakpt