Skip to content

gh-141510 Document and test frozendict class matching behaviour - #150799

Merged
vstinner merged 2 commits into
python:mainfrom
da-woods:frozendict-self-match
Jun 18, 2026
Merged

gh-141510 Document and test frozendict class matching behaviour#150799
vstinner merged 2 commits into
python:mainfrom
da-woods:frozendict-self-match

Conversation

@da-woods

@da-woodsda-woods commented Jun 2, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Frozendict has _Py_TPFLAGS_MATCH_SELF set so works correctly with the single-arg class matching. However it isn't documented in the list of classes this works with and it isn't tested.

The test is some way below the other similar tests but anything else would need a large renumbering

@da-woods
pythongh-58370Document and test frozendict class matching behaviour
091478e
Frozendict has `_Py_TPFLAGS_MATCH_SELF` set so works correctly
with the single-arg class matching. However it isn't documented
in the list of classes this works with and it isn't tested.
The test is some way below the other similar tests but anything
else would need a large renumbering
@bedevere-appbedevere-appBot mentioned this pull request Jun 2, 2026
Closed
@bedevere-appbedevere-appBot added awaiting review tests Tests in the Lib/test dir labels Jun 2, 2026
@da-woods

da-woods commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'm assuming this is fine to bundle onto the original frozendict issue, but can change that if needed

(...Although I originally linked it to a previous reject proposal by mistake...)

@read-the-docs-community

read-the-docs-communityBot commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33198800 | 📁 Comparing 60c7221 against main (f7e0fb6)

🔍 Preview build

118 files changed · + 2 added · ± 116 modified

+Added

±Modified

@da-woodsda-woods changed the title gh-58370 Document and test frozendict class matching behaviourgh-141510 Document and test frozendict class matching behaviourJun 4, 2026
@bedevere-appbedevere-appBot mentioned this pull request Jun 4, 2026
Closed
vstinner
vstinner reviewed Jun 18, 2026
View reviewed changes
Comment threadLib/test/test_patma.py Outdated
self.assertEqual(x, 0)
self.assertEqual(y, 1)

def test_patma_267(self):

@vstinnervstinnerJun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the rationale for using an identifier to name the test method. Can you rename it to test_patma_frozendict()?

@vstinner

vstinner commented Jun 18, 2026

Copy link
Copy Markdown
Member

Oh, I didn't notice that I copied _Py_TPFLAGS_MATCH_SELF flag when I implemented frozendict. Thanks for updating the tests and the doc!

@da-woods

da-woods commented Jun 18, 2026

Copy link
Copy Markdown
ContributorAuthor

Oh, I didn't notice that I copied _Py_TPFLAGS_MATCH_SELF flag when I implemented frozendict

I guess it isn't too late to remove the flag of you don't want it. But I think the flag makes sense.

I've updated the function name to be more descriptive

@vstinner
vstinner merged commit fd53ae1 into python:mainJun 18, 2026
51 checks passed
@vstinner

vstinner commented Jun 18, 2026

Copy link
Copy Markdown
Member

Thanks, I merged your change.

@da-woods
da-woods deleted the frozendict-self-match branch June 18, 2026 13:46
@vstinnervstinner added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 19, 2026
@miss-islington-app

miss-islington-appBot commented Jun 19, 2026

Copy link
Copy Markdown

Thanks @da-woods for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jun 19, 2026

Copy link
Copy Markdown

GH-151701 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 19, 2026
vstinner pushed a commit that referenced this pull request Jun 19, 2026
@miss-islington@da-woods
[3.15]gh-141510Document and test frozendict class matching behaviour (
7e36838
GH-150799) (#151701)
gh-141510 Document and test frozendict class matching behaviour (GH-150799)
Frozendict has `_Py_TPFLAGS_MATCH_SELF` set so works correctly
with the single-arg class matching. However it isn't documented
in the list of classes this works with and it isn't tested.
The test is some way below the other similar tests but anything
else would need a large renumbering.
(cherry picked from commit fd53ae1)
Co-authored-by: da-woods <dw-git@d-woods.co.uk>
pyctrl pushed a commit to pyctrl/cpython that referenced this pull request Jul 5, 2026
@da-woods@pyctrl
pythongh-141510Document and test frozendict class matching behaviour (…
4bc0cdd
…python#150799)
Frozendict has `_Py_TPFLAGS_MATCH_SELF` set so works correctly
with the single-arg class matching. However it isn't documented
in the list of classes this works with and it isn't tested.
The test is some way below the other similar tests but anything
else would need a large renumbering.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@da-woods@vstinner