Uh oh!
There was an error while loading. Please reload this page.
gh-145177: Bump emscripten version to 5.0.7 - #150896
Conversation
freakboy3742
left a comment
There was a problem hiding this comment.
Looks like the "new emscripten version" tooling worked as advertised... but exposed some fun runtime issues in the test suite.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
hoodmane
commented
Jun 4, 2026
Yeah I guess I'll have to debug what went wrong with ctypes. Maybe I can bisect the last good version... |
freakboy3742
commented
Jun 5, 2026
Closing this now that we've bumped to 4.0.19 |
hoodmane
commented
Jun 5, 2026
Well that is less of course. |
freakboy3742
commented
Jun 7, 2026
Oh sure; I closed this PR down because I assumed 4.0.19 was where we were going to leave things for now. Rather than leave an open PR in the queue, I figured we should close this one down. If you want to re-open it to keep getting to the bottom of the ctypes problem, go right ahead. |
hoodmane
commented
Jun 9, 2026
I will if I figure it out. |
Update the Emscripten compiler toolchain.