Uh oh!
There was an error while loading. Please reload this page.
gh-84649: Use statx() in TimedRotatingFileHandler if available - #150968
Merged
serhiy-storchaka merged 3 commits intoJun 6, 2026
Merged
gh-84649: Use statx() in TimedRotatingFileHandler if available#150968serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
serhiy-storchaka
left a comment
MemberAuthor
There was a problem hiding this comment.
@vstinner, could you please look at this? Do I use statx() like it is supposed to be used?
| @unittest.skipUnless(hasattr(os.stat_result, 'st_birthtime') or | ||
| support.has_st_birthtime or hasattr(os, 'statx'), | ||
| "st_birthtime and statx() not available or supported by Python on this OS") | ||
| # @support.requires_resource('walltime') |
MemberAuthor
There was a problem hiding this comment.
This is temporary, to run tests once on CI.
This allows to support rotation based on the file birth time on Linux.
serhiy-storchakaforce-pushed
the
TimedRotatingFileHandler-statx
branch
from
June 5, 2026 13:11
e584956 to
e1c910eComparevstinner
approved these changes
Jun 5, 2026
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. The code using os.statx() is correct. Don't forget to uncomment # @support.requires_resource('walltime').
| # Use stx_btime whenever it is available or use stx_ctime | ||
| # instead otherwise | ||
| creation_time = statx_result.stx_btime | ||
| if creation_time is None: |
Member
There was a problem hiding this comment.
Right, stx_btime can be None. For example, on a tmpfs filesystem, on Linux 5.17 and older: #83714 (comment).
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to support rotation based on the file birth time on Linux.