Skip to content

gh-151126: Fix missing memory errors in _interpchannelsmodule.c#151239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 3 commits into from
Jun 10, 2026
Merged

gh-151126: Fix missing memory errors in _interpchannelsmodule.c#151239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f4e2e8
gh-151126: Fix missing memory errors in `_interpchannelsmodule.c`
sobolevn Jun 10, 2026
9d52433
Fix docs
sobolevn Jun 10, 2026
96c750a
Fix docs
sobolevn Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-06-09-10-28-30.gh-issue-151126.DKa6Sl.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
Fix a crash, when there's no memory left on a device,
which happened in:

- code compilation
- :func:`!_winapi.CreateProcess`
which happened in: code compilation, :mod:`!_interpchannels` module,
:func:`!_winapi.CreateProcess` function.

Now these places raise proper :exc:`MemoryError` errors.
6 changes: 5 additions & 1 deletion Modules/_interpchannelsmodule.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -921,7 +921,8 @@ static _channelends *
_channelends_new(void)
{
_channelends *ends = GLOBAL_MALLOC(_channelends);
if (ends== NULL) {
if (ends == NULL) {
PyErr_NoMemory();
return NULL;
}
ends->numsendopen = 0;
Expand DownExpand Up@@ -1115,6 +1116,7 @@ _channel_new(PyThread_type_lock mutex, struct _channeldefaults defaults)
assert(check_unbound(defaults.unboundop));
_channel_state *chan = GLOBAL_MALLOC(_channel_state);
if (chan == NULL) {
PyErr_NoMemory();
return NULL;
}
chan->mutex = mutex;
Expand DownExpand Up@@ -1313,6 +1315,7 @@ _channelref_new(int64_t cid, _channel_state *chan)
{
_channelref *ref = GLOBAL_MALLOC(_channelref);
if (ref == NULL) {
PyErr_NoMemory();
return NULL;
}
ref->cid = cid;
Expand DownExpand Up@@ -1698,6 +1701,7 @@ _channel_set_closing(_channelref *ref, PyThread_type_lock mutex) {
}
chan->closing = GLOBAL_MALLOC(struct _channel_closing);
if (chan->closing == NULL) {
PyErr_NoMemory();
goto done;
}
chan->closing->ref = ref;
Expand Down
Loading