gh-151428: Remove unused imports from stdlib by hugovk · Pull Request #151478 · python/cpython

hugovk · 2026-06-14T16:38:09Z

Follow on from #151440 and #151442.

Also add Ruff F401 to help avoid this in the future, and exclude any files with false positives (rather than adding noqa comments).

Issue: Remove unused imports (June 2026) #151428

StanFromIreland

LGTM

Pablo might need to update his "Attracts linker errors" line to "Attracts linker errors and unused imports," I think I see a pattern in the affected files ;-)

johnslavik · 2026-06-15T13:30:39Z

Pablo might need to update his "Attracts linker errors" line to "Attracts linker errors and unused imports," I think I see a pattern in the affected files ;-)

Attracts lin[kt]er errors

AlexWaygood

(I only reviewed the changes to the config files)

AlexWaygood · 2026-06-15T13:34:19Z

+[per-file-target-version]
+"jit/example_trace_dump.py" = "py312" # Reused-quote f-strings (PEP 701)


should this be the target version for the whole jit directory, rather than just one file...?

Sure, updated.

AlexWaygood · 2026-06-15T13:35:52Z

+[lint.per-file-ignores]
+"c-analyzer/c_parser/__init__.py" = ["F401"] # Re-exports from submodules
+"c-analyzer/c_parser/preprocessor/__init__.py" = ["F401"] # Re-exports from submodules
+"c-analyzer/c_parser/preprocessor/common.py" = ["F401"] # Re-exported by preprocessor/__init__.py


Adding __all__ and listing the re-exports in __all__ would probably be a more idiomatic way of fixing these errors (but perhaps that's something for a followup PR, since there's a chance it could be controversial :-)

Will open a followup for this.

AlexWaygood · 2026-06-15T13:37:37Z

+
+[lint.per-file-ignores]
+"ctypes/__init__.py" = ["F401"] # Re-exports from _ctypes
+"ensurepip/__init__.py" = ["F401"] # `import zlib` availability check


in a case like this where there's only one error, I'd usually lean towards using a noqa comment in the code rather than per-file-ignores. But, again, perhaps that's best done as a followup..

And for this.

pablogsal · 2026-06-15T13:48:33Z

LGTM
Pablo might need to update his "Attracts linker errors" line to "Attracts linker errors and unused imports," I think I see a pattern in the affected files ;-)

Keeping those linters busy man 😉

vstinner

LGTM

vstinner · 2026-06-16T16:14:02Z

+[lint]
+select = [
+ "F401", # Unused import
+]


Is it needed to repeat it? It's already in the parent (project) configuration, no?

The parent config doesn't define a select, so defaults to ["E4", "E7", "E9", "F"].
We don't want to run the whole F category, or those other ones, so this select overwrites that one.
(There is an extend-select that is in addition to select, but we do want a smaller set here.)

Oh sorry, I mixed Lib/.ruff.toml and .ruff.toml. You're right.

bedevere-app · 2026-07-02T20:38:28Z

GH-152916 is a backport of this pull request to the 3.15 branch.

…) (#152916)

…) (GH-152916) (#152918) [3.15] gh-151428: Remove unused imports in idlelib.idle_test (GH-151478) (GH-152916) (cherry picked from commit 984ebbf) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

…) (GH-152916) (#152917) [3.15] gh-151428: Remove unused imports in idlelib.idle_test (GH-151478) (GH-152916) (cherry picked from commit 984ebbf) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Remove unused stdlib imports and add Ruff F401
5b7971d

hugovk requested review from AA-Turner, AlexWaygood, ambv, lysnikolaou, pablogsal and terryjreedy as code owners June 14, 2026 16:38

bedevere-appBot added the awaiting core review label Jun 14, 2026

bedevere-appBot mentioned this pull request Jun 14, 2026
Remove unused imports (June 2026) #151428
Closed

hugovk added skip news and removed awaiting core review labels Jun 14, 2026

Add Ruff F401 to Tools/
2a91bf0

StanFromIreland reviewed Jun 14, 2026
View reviewed changes

Comment thread.pre-commit-config.yaml

StanFromIreland approved these changes Jun 14, 2026
View reviewed changes

bedevere-appBot added the awaiting merge label Jun 14, 2026

AlexWaygood approved these changes Jun 15, 2026
View reviewed changes

Use per-file-target-version=py312 for Tools/jit/*.py
ce9c770

vstinner approved these changes Jun 16, 2026
View reviewed changes

hugovk merged commit 627adb5 into python:mainJun 16, 2026
57 checks passed

hugovk deleted the 3.16-rm-unused-imports branch June 16, 2026 16:31

bedevere-appBot removed the awaiting merge label Jun 16, 2026

philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
pythongh-151428: Remove unused imports from stdlib (python#151478)
f7beda0

terryjreedy added a commit that referenced this pull request Jul 2, 2026
[3.15]gh-151428: Remove unused imports in idlelib.idle_test (GH-151478…
984ebbf
…) (#152916)

		[per-file-target-version]
		"jit/example_trace_dump.py" = "py312" # Reused-quote f-strings (PEP 701)

Uh oh!

Uh oh!

Conversation

hugovk commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

StanFromIreland left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnslavik commented Jun 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pablogsal commented Jun 15, 2026

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-appBot commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hugovk commented Jun 14, 2026•
edited
Loading

StanFromIreland left a comment •
edited
Loading

johnslavik commented Jun 15, 2026•
edited
Loading