Skip to content

gh-151126:Fix missing memory errors in _interpretersmodule.c - #151624

Merged
sobolevn merged 2 commits into
python:mainfrom
lpyu001:fix-missing-PyErr_NoMemory-in-_interpretersmodule.c
Jun 25, 2026
Merged

gh-151126:Fix missing memory errors in _interpretersmodule.c#151624
sobolevn merged 2 commits into
python:mainfrom
lpyu001:fix-missing-PyErr_NoMemory-in-_interpretersmodule.c

Conversation

@lpyu001

@lpyu001lpyu001 commented Jun 18, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Jun 18, 2026
Open
sobolevn
sobolevn approved these changes Jun 25, 2026
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevnsobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 25, 2026
@sobolevn
sobolevn merged commit 05225aa into python:mainJun 25, 2026
64 checks passed
@miss-islington-app

miss-islington-appBot commented Jun 25, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152169 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 25, 2026
@miss-islington-app

miss-islington-appBot commented Jun 25, 2026

Copy link
Copy Markdown

Sorry, @lpyu001 and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 05225aa06a4c5eceaa2eb29e99c2d44d2dbfe295 3.13

@bedevere-app

bedevere-appBot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152170 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2026
@sobolevn

sobolevn commented Jun 25, 2026

Copy link
Copy Markdown
Member

@lpyu001 can you please check why did the 3.13 backport failed? Do we need one?

sobolevn pushed a commit that referenced this pull request Jun 25, 2026
@miss-islington@lpyu001
[3.14]gh-151126: Fix missing memory errors in_interpretersmodule.c(
7b16d6c
GH-151624) (#152170)
gh-151126: Fix missing memory errors in `_interpretersmodule.c` (GH-151624)
(cherry picked from commit 05225aa)
Co-authored-by: stevens <lipengyu@kylinos.cn>
sobolevn pushed a commit that referenced this pull request Jun 25, 2026
@miss-islington@lpyu001
[3.15]gh-151126: Fix missing memory errors in_interpretersmodule.c(
0650619
GH-151624) (#152169)
gh-151126: Fix missing memory errors in `_interpretersmodule.c` (GH-151624)
(cherry picked from commit 05225aa)
Co-authored-by: stevens <lipengyu@kylinos.cn>
@serhiy-storchaka

serhiy-storchaka commented Jul 15, 2026

Copy link
Copy Markdown
Member

Please don't forget about backports.

@bedevere-app

bedevere-appBot commented Jul 15, 2026

Copy link
Copy Markdown

GH-153765 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 15, 2026
@lpyu001

lpyu001 commented Jul 15, 2026

Copy link
Copy Markdown
ContributorAuthor

Please don't forget about backports.

Done. Thanks!

@lpyu001

lpyu001 commented Jul 15, 2026

Copy link
Copy Markdown
ContributorAuthor

@lpyu001 can you please check why did the 3.13 backport failed? Do we need one?

3.13 still uses the older cross-interpreter buffer implementation. The same missing-exception paths are present there,I've backport it to 3.13

sobolevn pushed a commit that referenced this pull request Jul 15, 2026
@lpyu001
[3.13]gh-151126: Fix missing memory errors in_interpretersmodule.c(
8010bf0
#153765)
gh-151126: Fix missing memory errors in `_interpretersmodule.c` (#151624)
(cherry picked from commit 05225aa)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

@sobolevnsobolevn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lpyu001@sobolevn@serhiy-storchaka