Skip to content

gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo() - #151671

Merged
encukou merged 3 commits into
python:mainfrom
dnicolodi:fix/win-tarfile-gettarinfo
Jul 10, 2026
Merged

gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo()#151671
encukou merged 3 commits into
python:mainfrom
dnicolodi:fix/win-tarfile-gettarinfo

Conversation

@dnicolodi

@dnicolodidnicolodi commented Jun 18, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This applies a normalization complementary to the one added to tarfile.TarFile.extract() in gh-138309.

@dnicolodi
pythongh-151669: Normalize symlink targets in tarfile.TarFile.gettari…
b05605c
…nfo()
This applies a normalization complementary to the one added to
tarfile.TarFile.extract() in pythongh-138309.
@python-cla-bot

python-cla-botBot commented Jun 18, 2026•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appBot mentioned this pull request Jun 18, 2026
Closed
@dnicolodi

dnicolodi commented Jun 18, 2026

Copy link
Copy Markdown
ContributorAuthor

I think this change should be mentioned in NEWS next to the one to extract(). However, I don't know how amending exiting entries in NEWS is handled.

@dnicolodidnicolodi mentioned this pull request Jun 19, 2026
Closed
@bonzini

bonzini commented Jun 19, 2026

Copy link
Copy Markdown

According to the CI message, the news entry should be added to Misc/NEWS.d/next

@dnicolodi

dnicolodi commented Jun 19, 2026

Copy link
Copy Markdown
ContributorAuthor

According to the CI message, the news entry should be added to Misc/NEWS.d/next

I understand this, but in this case I think the best would be to extend the NEWS entry added by gh-138309, and I don't know what is the policy for doing this.

@ngoldbaum

ngoldbaum commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Ping @encukou - @mgorny tells me this PR is needed by meson to add Python 3.15 and abi3t support.

@rgommersrgommers mentioned this pull request Jun 24, 2026
Merged
@ngoldbaum

ngoldbaum commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@hugovk can you help clarify how the news entry should be handled here? Should @dnicolodi simply add a new one?

@hugovk

hugovk commented Jun 24, 2026

Copy link
Copy Markdown
Member

The changelog is a never-ending history of archeological layers.

The NEWS entry added by #138309 is what happened in 3.15.0a1. That's the past.

The NEWS entry for this PR is what will happen in 3.15.0b4. Please add a new NEWS entry for this change.

General info: https://devguide.python.org/getting-started/pull-request-lifecycle/#updating-news-and-what-s-new-in-python

@read-the-docs-community

read-the-docs-communityBot commented Jun 24, 2026•
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33499371 | 📁 Comparing 43e66d5 against main (1d55b37)

🔍 Preview build

92 files changed · ± 91 modified · - 1 deleted

±Modified

-Deleted

@dnicolodi
dnicolodiforce-pushed the fix/win-tarfile-gettarinfo branch from 630da42 to 52b2be0CompareJune 24, 2026 21:51
@rgommersrgommers mentioned this pull request Jun 27, 2026
Merged
@dnicolodi

dnicolodi commented Jul 5, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@hugovk gave his approval for merging this #138309 (comment) Is there anything I can help with to have this merged? @encukou

@ngoldbaum

ngoldbaum commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Also just in case it isn't clear, fixing this is needed for meson-python to correctly create sdists on Windows using Python 3.15.

@encukou

encukou commented Jul 6, 2026

Copy link
Copy Markdown
Member

Do you want to add a test as well? If not I'll add one later this week.

@dnicolodi

dnicolodi commented Jul 8, 2026

Copy link
Copy Markdown
ContributorAuthor

I've added a test. I am not very familiar with the organization of tests in the CPython codebase. Please let me know if it should be improved somehow.

@dnicolodi

dnicolodi commented Jul 8, 2026

Copy link
Copy Markdown
ContributorAuthor

Tests / CIFuzz / python3-libraries (address) fails at the build stage, thus it is not connected to the changes in this PR.

@encukouencukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 9, 2026
@bedevere-bot

bedevere-bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 43e66d5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F151671%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 9, 2026
@encukouencukou added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 10, 2026
@encukou
encukou merged commit cc31641 into python:mainJul 10, 2026
149 of 154 checks passed
@miss-islington-app

miss-islington-appBot commented Jul 10, 2026

Copy link
Copy Markdown

Thanks @dnicolodi for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jul 10, 2026

Copy link
Copy Markdown

GH-153517 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 10, 2026
hugovk pushed a commit that referenced this pull request Jul 17, 2026
@miss-islington@dnicolodi
[3.15]gh-151669: Normalize symlink targets in tarfile.TarFile.gettar…
fefc0b4
…info() (GH-151671) (#153517)
Co-authored-by: Daniele Nicolodi <daniele@grinta.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dnicolodi@bonzini@ngoldbaum@hugovk@encukou@bedevere-bot