Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 35.3k
gh-152384: pixi-packages: use flags to define variants#152385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8b5b0c281c8972b226f355cba45cf152ba718c12e644c27dba608b308af45b32b0552201a12c808807bb330239c036f9a3d72075bde788e8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| The CPython Pixi packages are now all accessible at the same | ||
| ``Tools/pixi-packages`` subdirectory, rather than at | ||
| ``Tools/pixi-packages/{variant}`` as before. Variants are now selected not | ||
| via subdirectory but via ``flags``; see | ||
| https://pixi.prefix.dev/latest/concepts/package_specifications/#extras-and-flags | ||
| for usage instructions. The ``tsan-freethreading`` variant has been renamed | ||
| to ``tsan_freethreading``, while the ``default``, ``asan``, and | ||
| ``freethreading`` variants retain their previous names. |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,9 @@ | ||
| # NOTE: Please always only modify default/pixi.toml and then run clone-recipe.sh to | ||
| # propagate the changes to the other variants. | ||
| [workspace] | ||
| channels = ["https://prefix.dev/conda-forge"] | ||
| platforms = ["linux-64", "linux-aarch64", "osx-64", "osx-arm64"] | ||
| preview = ["pixi-build"] | ||
| requires-pixi = ">=0.66.0" | ||
| requires-pixi = ">=0.72.2" | ||
| [package.build.backend] | ||
| name = "pixi-build-rattler-build" | ||
| version = "*" | ||
| [package.build.config] | ||
| recipe = "../default/recipe.yaml" |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
lucascolley marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| version: ["3.16"] | ||
| variant: ["default", "asan", "freethreading", "tsan_freethreading"] | ||
| openssl: | ||
| - '3.5' | ||
| # match `.github/workflows/reusable-san.yml` | ||
| c_compiler: | ||
| - clang | ||
| c_compiler_version: | ||
| - 21 | ||
| cxx_compiler: | ||
| - clangxx | ||
| cxx_compiler_version: | ||
| - 21 | ||
kumaraditya303 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to remove the
-from this variant name, given that it is invalid in theflagsfield: https://conda.org/learn/ceps/cep-0045#repodata-record-syntaxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me, I think you and @crusaderky are just about the only users of these builds so far for what its worth