Uh oh!
There was an error while loading. Please reload this page.
gh-152433: Windows: allow build mimalloc for UWP - #152477
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
prim.c for UWPUh oh!
There was an error while loading. Please reload this page.
chris-eibl
commented
Jul 6, 2026
LGTM considering @zooba's #152433 (comment). cc @colesbury who tracks mimalloc differences from upstream in #113141. |
zooba
commented
Jul 14, 2026
This change looks fine, if we're maintaining the sources separately. If we're trying to track upstream closely, then we'll need them to make the change first. That's @colesbury's call, it seems. |
zware
commented
Jul 18, 2026
Our copy of |
colesbury
commented
Jul 19, 2026
Yeah, if it's not CPython specific, please also open a PR in upstream mimalloc. |
thexai
commented
Jul 24, 2026
Patch submitted to upstream (microsoft/mimalloc#1340). Note is a bit different because I think PR can still be merged here because it doesn't do any harm and in the future it will be overwritten by whatever is upstream. |
Uh oh!
There was an error while loading. Please reload this page.
thexai
commented
Aug 1, 2026
The fix has been merged in the mimalloc |
chris-eibl
commented
Aug 1, 2026
May I trouble you to make this PR look closer to the diff that has been merged upstream? For instance, there |
thexai
commented
Aug 1, 2026
PR updated with almost same commit that upstream. |
prim.c for UWPmimalloc for UWPI tested the updated PR on Xbox and not even compiles due a missing header 😒 PR updated with the fix. (the header was already present in the first version of the PR) |
thexai
commented
Aug 4, 2026
Finally found that And most changes are not necessary 😊 |
All changes are trivial:
Remove some run-time dynamic linking and replace some
LoadLibrarywithLoadPackagedLibraryfor UWP.