Skip to content

gh-152433: Windows: _ssl module: improve UWP compatibility - #152791

Merged
zooba merged 1 commit into
python:mainfrom
thexai:uwp-_ssl
Jul 6, 2026
Merged

gh-152433: Windows: _ssl module: improve UWP compatibility#152791
zooba merged 1 commit into
python:mainfrom
thexai:uwp-_ssl

Conversation

@thexai

@thexaithexai commented Jul 1, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Windows: _ssl module: improve UWP compatibility.

@thexai
thexai requested review from a team, gpshead and picnixz as code ownersJuly 1, 2026 14:41
@bedevere-appbedevere-appBot mentioned this pull request Jul 1, 2026
Open
picnixz
picnixz reviewed Jul 1, 2026
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please use if defined() and elif defined(MS_WINDOWS) && ... and else for the fallback branch.
  • Can you determine why we are only raising a NotImplementedError on MS DEBUG builds for those functions? it's a separate issue but I think we should also raise unconditionally (or does it mean that those functions are available on regular MS builds only in release builds?) If there is something worth investigating, you can open a separate issue for that.

Comment threadModules/_ssl/debughelpers.c Outdated
Comment threadModules/_ssl.c Outdated
@thexai
thexaiforce-pushed the uwp-_ssl branch 2 times, most recently from 834b4c3 to 4db23b3CompareJuly 3, 2026 14:42
picnixz
picnixz reviewed Jul 3, 2026
View reviewed changes
Comment threadModules/_ssl/debughelpers.c Outdated
picnixz
picnixz reviewed Jul 3, 2026
View reviewed changes
Comment threadMisc/NEWS.d/next/Windows/2026-07-01-16-38-24.gh-issue-152433.jvEiHh.rst Outdated
picnixz
picnixz approved these changes Jul 3, 2026
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was small enough and changes were easy to spot, but in the future, please avoid force pushing once someone started reviewing your PR as it makes incremental review much harder. We squash merge at the end and change the commit messages ourselves when necessary.

@thexaithexai closed this Jul 4, 2026
@thexaithexai reopened this Jul 4, 2026
@zoobazooba added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 6, 2026
@zooba
zooba merged commit 4221ce7 into python:mainJul 6, 2026
103 of 105 checks passed
@miss-islington-app

miss-islington-appBot commented Jul 6, 2026

Copy link
Copy Markdown

Thanks @thexai for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jul 6, 2026

Copy link
Copy Markdown

GH-153216 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 6, 2026
thexai added a commit to thexai/cpython that referenced this pull request Jul 17, 2026
@thexai
pythongh-152433: Allow _ssl module to build for Windows UWP API set (p…
2f58162
…ythonGH-152791)
@thexai
thexai deleted the uwp-_ssl branch July 19, 2026 19:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoobazoobazooba left review comments
@picnixzpicnixzpicnixz approved these changes
@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thexai@zooba@picnixz