Uh oh!
There was an error while loading. Please reload this page.
gh-152433: Windows: _uuid module: improve UWP compatibility - #152793
Merged
Conversation
chris-eibl
approved these changes
Jul 6, 2026
picnixz
commented
Jul 7, 2026
Member
You can definitely keep the NEWS entry btw. Just say the same things that we did for the SSL module (namely build compatibility). |
thexai
commented
Jul 7, 2026
ContributorAuthor
Removed NEWS based on #153095 (comment) |
picnixz
commented
Jul 7, 2026
Member
Oh I see. Ok, but once you are done with all your changes, please add a NEWS entry that mention we improved several modules build compatibility (you can list them). It is still worthwhile IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows:
_uuidmodule: improve UWP compatibility.