Skip to content

gh-152433: Windows: allow posixmodule.c to build for Windows UWP - #152998

Merged
zooba merged 3 commits into
python:mainfrom
thexai:uwp-posixmodule
Jul 14, 2026
Merged

gh-152433: Windows: allow posixmodule.c to build for Windows UWP#152998
zooba merged 3 commits into
python:mainfrom
thexai:uwp-posixmodule

Conversation

@thexai

@thexaithexai commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Windows: allow posixmodule.c to build for Windows UWP.

@cmaloney

Copy link
Copy Markdown
Contributor

Please don't force push to CPython PR Branches.

The issue description here is a little confusing as this shows up as the module nt (posixmodule.c is exported as nt on windows and posix elsewhere). Would be better to have the NEWs refer to the module as that is what users of CPython see in their codebase:

:mod:`!nt`:

(The ! at the start is because there isn't a dedicated module page for nt currently in the docs although there probably should be).

For the windows specific pieces need review from @python/windows-team

@zooba

zooba commented Jul 6, 2026

Copy link
Copy Markdown
Member

The change looks fine to me, and in line with my comments on the other PR we merged earlier today, let's just skip NEWS here (all that changes is that a failing custom build becomes a successful one).

@thexai

Copy link
Copy Markdown
ContributorAuthor

NEWS removed.

@zooba

zooba commented Jul 6, 2026

Copy link
Copy Markdown
Member

I'm sure you'll be told again, but every time you force push a small change, we cannot verify your change. You force us to re-review the entire pull request again, because the incremental change you made is gone.

That annoys us and slows us down. You'll get fewer reviews and find it harder to get your changes merged.

Please just work with us here. We always squash merge, so intermediate commits won't show up anyway, and we usually rewrite commit messages to make sure the important information is included. The commit history within a PR is there to serve the reviewers, and force pushing is the best way to not serve the reviewers.

@thexai

Copy link
Copy Markdown
ContributorAuthor

I understand, but I only removed NEWS and assumed it was the easiest way.

@thexaithexai closed this Jul 14, 2026
@thexaithexai reopened this Jul 14, 2026
Comment threadModules/posixmodule.c Outdated
@zooba
zooba merged commit ba28946 into python:mainJul 14, 2026
92 of 94 checks passed
@zooba

Copy link
Copy Markdown
Member

Thanks!

@thexai
thexai deleted the uwp-posixmodule branch July 15, 2026 15:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thexai@cmaloney@zooba