Skip to content

bpo-37836: document as_integer_ratio() in the data model - #15328

Closed
jdemeyer wants to merge 1 commit into
python:mainfrom
jdemeyer:datamodel_as_integer_ratio
Closed

bpo-37836: document as_integer_ratio() in the data model#15328
jdemeyer wants to merge 1 commit into
python:mainfrom
jdemeyer:datamodel_as_integer_ratio

Conversation

@jdemeyer

@jdemeyerjdemeyer commented Aug 18, 2019

Copy link
Copy Markdown
Contributor

@rhettinger

Copy link
Copy Markdown
Contributor

You should get Guido to opine on this. I think you're making this more official and pervasive and prescriptive than he intended.

There is a difference between making a helpful utility available versus trying to make everyone change their code to use it.

@jdemeyer

Copy link
Copy Markdown
ContributorAuthor

I made this a draft PR since the doc says

This is used for conversion to :class:`fractions.Fraction`

but this is not yet true at the moment. So it depends on either #15327 (by me) or #15329 (by @serhiy-storchaka).

@jdemeyer
jdemeyer marked this pull request as ready for review August 21, 2019 09:33
@AA-Turner

Copy link
Copy Markdown
Member

The linked issue was closed (#82017 (comment)) -- should this PR remain?

A

@gvanrossum

Copy link
Copy Markdown
Member

Let's close it, since everything else related to this was closed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting mergeDO-NOT-MERGEdocsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jdemeyer@rhettinger@AA-Turner@gvanrossum@the-knights-who-say-ni@bedevere-bot