Skip to content

gh-143750: Compile OpenSSL with TSan for TSan CI - #153316

Merged
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:gh-143750-openssl-tsan
Jul 8, 2026
Merged

gh-143750: Compile OpenSSL with TSan for TSan CI#153316
kumaraditya303 merged 5 commits into
python:mainfrom
kumaraditya303:gh-143750-openssl-tsan

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Jul 8, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This PR supersedes #143752 and builds openssl with tsan for tsan CI to avoid false-positives.

@bedevere-appbedevere-appBot mentioned this pull request Jul 8, 2026
Closed
colesburyand others added 2 commits July 8, 2026 15:37
@colesbury@kumaraditya303
pythongh-143750: Compile OpenSSL with TSan for TSan CI
06b4de4
- Also fix "Install dependencies" step so that we use the installed Clang.
We can use clang-20 on both ASan and TSan now.
@kumaraditya303
Revert "Temporarily allow the TSan (free-threading) job to fail (pyth…
c25b785
…on#152173)"
This reverts commit 4f39efc.
@kumaraditya303
kumaraditya303force-pushed the gh-143750-openssl-tsan branch from 8936cbc to c25b785CompareJuly 8, 2026 10:09
@kumaraditya303kumaraditya303 mentioned this pull request Jul 8, 2026
Open
@kumaraditya303
kumaraditya303 marked this pull request as ready for review July 8, 2026 11:13
webknjaz
webknjaz reviewed Jul 8, 2026
View reviewed changes

@webknjazwebknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, seems good, but I have a few cosmetic notes.

Comment thread.github/workflows/reusable-san.yml Outdated
Comment thread.github/workflows/reusable-san.yml Outdated
Comment thread.github/workflows/reusable-san.yml
Comment thread.github/workflows/reusable-san.yml Outdated
Comment thread.github/workflows/reusable-san.yml Outdated
Comment thread.github/workflows/reusable-san.yml Outdated
Comment thread.github/workflows/reusable-san.yml
webknjaz
webknjaz reviewed Jul 8, 2026
View reviewed changes
Comment thread.github/workflows/reusable-san.yml
webknjaz
webknjaz approved these changes Jul 8, 2026
View reviewed changes

@webknjazwebknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303
kumaraditya303 merged commit fc19ad7 into python:mainJul 8, 2026
48 checks passed
@kumaraditya303
kumaraditya303 deleted the gh-143750-openssl-tsan branch July 8, 2026 15:15
@kumaraditya303kumaraditya303 added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 8, 2026
@miss-islington-app

miss-islington-appBot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-appBot commented Jul 8, 2026

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc19ad7b8b08c43667c9087d89f32f08830544ce 3.14

@miss-islington-app

miss-islington-appBot commented Jul 8, 2026

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc19ad7b8b08c43667c9087d89f32f08830544ce 3.15

@bedevere-app

bedevere-appBot commented Jul 8, 2026

Copy link
Copy Markdown

GH-153353 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 8, 2026
@bedevere-app

bedevere-appBot commented Jul 8, 2026

Copy link
Copy Markdown

GH-153355 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 8, 2026
kumaraditya303 added a commit that referenced this pull request Jul 8, 2026
@kumaraditya303@colesbury
[3.15]gh-143750: Compile OpenSSL with TSan for TSan CI (#153316) (#1…
6af15c9
…53353)
gh-143750: Compile OpenSSL with TSan for TSan CI (#153316)
(cherry picked from commit fc19ad7)
Co-authored-by: Sam Gross <colesbury@gmail.com>
kumaraditya303 added a commit that referenced this pull request Jul 10, 2026
@kumaraditya303@colesbury
[3.14]gh-143750: Compile OpenSSL with TSan for TSan CI (#153316) (#1…
b49ec81
…53355)
Compile OpenSSL with TSan in the TSan CI job so that data races between
Python code and OpenSSL internals are visible to the sanitizer.
Also skip test_ssl_in_multiple_threads under TSan: concurrent calls to
SSLContext.load_cert_chain on the same context race on the SSL_CTX
default password callback. The race is fixed in 3.15+ (GH-143818), but
with TSan-instrumented OpenSSL it is now reported on 3.14.
(cherry picked from commit fc19ad7)
Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjazwebknjazwebknjaz approved these changes
@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner
@picnixzpicnixzAwaiting requested review from picnixzpicnixz is a code owner
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@itamaroitamaroAwaiting requested review from itamaroitamaro is a code owner
@JacobCoffeeJacobCoffeeAwaiting requested review from JacobCoffeeJacobCoffee is a code owner

Assignees

@kumaraditya303kumaraditya303

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303@webknjaz@colesbury