Skip to content

gh-152216: Silence expat compiler warnings - #153671

Closed
cdce8p wants to merge 1 commit into
python:mainfrom
cdce8p:silence-expat-compiler-warnings
Closed

gh-152216: Silence expat compiler warnings#153671
cdce8p wants to merge 1 commit into
python:mainfrom
cdce8p:silence-expat-compiler-warnings

Conversation

@cdce8p

@cdce8pcdce8p commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Silence expat compiler warnings on macOS with clang.

Infileincludedfrom ./Modules/expat/xmltok.c:309:
./Modules/expat/xmltok_impl.c:283:5: warning: fallthroughannotationinunreachablecode [-Wunreachable-code-fallthrough]
283 | CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
| ^
./Modules/expat/xmltok_impl.c:116:5: note: expandedfrommacro'CHECK_NMSTRT_CASES'116 | EXPAT_FALLTHROUGH; \
| ^
./Modules/expat/fallthrough.h:45:33: note: expandedfrommacro'EXPAT_FALLTHROUGH'45 | # defineEXPAT_FALLTHROUGH __attribute__((fallthrough))
| ^
...

@StanFromIreland

Copy link
Copy Markdown
Member

As I noted in the issue, we won't be doing this.

@cdce8p
cdce8p deleted the silence-expat-compiler-warnings branch July 14, 2026 17:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cdce8p@StanFromIreland