Uh oh!
There was an error while loading. Please reload this page.
gh-151763: Fix crash in PyList_New() on allocation failure under low memory - #154019
Open
Abhi210 wants to merge 5 commits into
Open
gh-151763: Fix crash in PyList_New() on allocation failure under low memory#154019Abhi210 wants to merge 5 commits into
Abhi210 wants to merge 5 commits into
Conversation
| } | ||
| else { | ||
| op->ob_item = NULL; | ||
| Py_SET_SIZE(op, 0); |
Contributor
There was a problem hiding this comment.
The following two commands are safe, IIUC.
Suggested change
| Py_SET_SIZE(op, 0); | |
| op->allocated=0; | |
| Py_SET_SIZE(op, size); |
Contributor
There was a problem hiding this comment.
And then we can remove this Py_SET_SIZE.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Abhi210force-pushed
the
gh-152125
branch
2 times, most recently
from
July 19, 2026 13:36
8480542 to
cfee4d2Compare| else { | ||
| op->ob_item = NULL; | ||
| Py_SET_SIZE(op, size); | ||
| op->allocated = size; |
Contributor
There was a problem hiding this comment.
No, main idea to set size here, and set allocated=size before GC track. allocated is a gate which stops readers from reading not initialized memory.
So, I propose something like:
op->ob_item = NULL;
op->allocated = 0;
Py_SET_SIZE(op, size);
// ...
// ...
op->allocated = size;
_PyObject_GC_TRACK(op);
ContributorAuthor
There was a problem hiding this comment.
Ok! I have made the suggested changes. Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesgh-152125 (one of the OOM-injection fuzzing findings tracked under the gh-151763 umbrella).