Skip to content

gh-154189: Fix use-after-free in functools.partial_vectorcall - #154508

Merged
encukou merged 2 commits into
python:mainfrom
brijkapadia:partial-vectorcall
Jul 24, 2026
Merged

gh-154189: Fix use-after-free in functools.partial_vectorcall#154508
encukou merged 2 commits into
python:mainfrom
brijkapadia:partial-vectorcall

Conversation

@brijkapadia

@brijkapadiabrijkapadia commented Jul 22, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Jul 22, 2026
Closed
@brijkapadia

brijkapadia commented Jul 22, 2026

Copy link
Copy Markdown
ContributorAuthor

@encukou, could you review this whenever you have time?
I'm asking since you reviewed #145362, which is similar to this pr.

encukou
encukou approved these changes Jul 24, 2026
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This checks out. Are you up for a bit of additional cleanup?

Comment threadModules/_functoolsmodule.c Outdated
Comment threadModules/_functoolsmodule.c Outdated
encukou
encukou approved these changes Jul 24, 2026
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukouencukou added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 24, 2026
@encukou
encukou merged commit 1a742d4 into python:mainJul 24, 2026
62 of 63 checks passed
@miss-islington-app

miss-islington-appBot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @brijkapadia for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 24, 2026

Copy link
Copy Markdown

Sorry, @brijkapadia and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a742d403243ac9915ffcc54e29516e58c44dc42 3.14

@bedevere-app

bedevere-appBot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154652 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 24, 2026
@brijkapadia
brijkapadia deleted the partial-vectorcall branch July 24, 2026 21:42
@brijkapadia

brijkapadia commented Jul 25, 2026

Copy link
Copy Markdown
ContributorAuthor

I don't think PR needs to be backported to 3.14.

encukou pushed a commit that referenced this pull request Jul 27, 2026
@miss-islington@brijkapadia
[3.15]gh-154189: Fix use-after-free infunctools.partial_vectorcall(
6246342
GH-154508) (#154652)
(cherry picked from commit 1a742d4)
Co-authored-by: Brij Kapadia <97006829+brijkapadia@users.noreply.github.com>
@encukou

encukou commented Jul 27, 2026

Copy link
Copy Markdown
Member

I agree; it doesn't look worth the effort.

@encukouencukou removed the needs backport to 3.14 bugs and security fixes label Jul 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou approved these changes
@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees

@encukouencukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brijkapadia@encukou