Skip to content

gh-154539: Use atomic read and write with should_auto_add_history#154531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xxyzz wants to merge 1 commit into
base:main
Choose a base branch
from
Open

gh-154539: Use atomic read and write with should_auto_add_history#154531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modules/readline.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -841,7 +841,7 @@ readline_set_auto_history_impl(PyObject *module,
int _should_auto_add_history)
/*[clinic end generated code: output=619c6968246fd82b input=3d413073a1a03355]*/
{
should_auto_add_history = _should_auto_add_history;
FT_ATOMIC_STORE_INT_RELAXED(should_auto_add_history, _should_auto_add_history);
Py_RETURN_NONE;
}

Expand DownExpand Up@@ -1590,7 +1590,7 @@ call_readline(FILE *sys_stdin, FILE *sys_stdout, const char *prompt)

/* we have a valid line */
n = strlen(p);
if (should_auto_add_history && n > 0) {
if (FT_ATOMIC_LOAD_INT_RELAXED(should_auto_add_history) && n > 0) {
const char *line;
int length = _py_get_history_length_lock_held();
if (length > 0) {
Expand Down
Loading