Skip to content

gh-154196: Improve AttributeError messages from unresolved lazy imports - #154688

Open
johnslavik wants to merge 8 commits into
python:mainfrom
johnslavik:gh-154196
Open

gh-154196: Improve AttributeError messages from unresolved lazy imports#154688
johnslavik wants to merge 8 commits into
python:mainfrom
johnslavik:gh-154196

Conversation

@johnslavik

@johnslavikjohnslavik commented Jul 25, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@johnslavik
johnslavik requested a review from vstinnerJuly 25, 2026 11:10
@bedevere-appbedevere-appBot mentioned this pull request Jul 25, 2026
Open
@johnslavik

johnslavik commented Jul 26, 2026

Copy link
Copy Markdown
MemberAuthor

Merging latest main to fix CI.

pablogsal
pablogsal reviewed Aug 10, 2026
View reviewed changes
Comment threadLib/test/test_lazy_import/__init__.py Outdated
Comment threadObjects/lazyimportobject.c Outdated
Comment threadObjects/lazyimportobject.c Outdated
Comment threadObjects/lazyimportobject.c Outdated
Comment threadLib/test/test_lazy_import/__init__.py
@johnslavik

johnslavik commented Aug 10, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thank you so much for reviewing @pablogsal! I've addressed all threads.

vstinner
vstinner approved these changes Aug 10, 2026
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal left review comments
@vstinnervstinnervstinner approved these changes
@Yhg1sYhg1sAwaiting requested review from Yhg1sYhg1s is a code owner
@DinoVDinoVAwaiting requested review from DinoVDinoV is a code owner
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting mergetopic-lazy-imports

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnslavik@vstinner@pablogsal