Uh oh!
There was an error while loading. Please reload this page.
gh-154902: Add an intrinsic for conditional annotations - #155026
Merged
Conversation
deadlovelll
requested review from
JelleZijlstra, iritkatriel and markshannon
as code ownersAugust 1, 2026 12:30
sobolevn
reviewed
Aug 1, 2026
| # gh-154902 | ||
| def test_conditional_annotations_rebound_via_globals(self): | ||
| code = """ | ||
| globals()["__conditional_annotations__"] = 0 |
Member
There was a problem hiding this comment.
I guess we can parametrize both left side and right side:
{left} = {value}ContributorAuthor
There was a problem hiding this comment.
thank you! just pushed the changes
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: sobolevn <mail@sobolevn.me>
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Thanks, this makes sense.
I think you'll also have to increase the bytecode magic number.
ContributorAuthor
Thank you! Just pushed this, also added new intrinsic to the doc |
Documentation build overview
|
JelleZijlstra
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an intrinsic for conditional annotations to avoid user to change them
For more details and discussion see gh-154902