Uh oh!
There was an error while loading. Please reload this page.
gh-153711: Add runtime guards for dup3 & pipe2 - #155174
Open
encukou wants to merge 6 commits into
Open
Conversation
Based on pythonGH-154718 Co-Authored-By: Vamsi-klu <nrvamsi13@gmail.com>
Documentation build overview
|
ned-deily
requested changes
Aug 5, 2026
ned-deily
left a comment
Member
There was a problem hiding this comment.
Other than the two minor fixes for legacy builds, this looks really good. I built and ran test_os on macOS 26 and 27 and on macOS 10.15 with no build failures or regressions. Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
When you're done making the requested changes, leave the comment: |
ned-deily
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on GH-154718 -- I made some changes, then checked @Vamsi-klu's closed PR and realized the work is already nearly done. So, credit where it's due.
This is for macOS only; extending to iOS & others should not be hard but it seems best to test on desktop first.
@ned-deily, do you have the hardware/software to test this easily?