Skip to content

gh-155339: Document the change of behaviour about parsing negative numbers from 3.14 in argparse - #155340

Merged
savannahostrowski merged 4 commits into
python:mainfrom
ptim0626:docs-clarify-argparse-neg-num
Aug 8, 2026
Merged

gh-155339: Document the change of behaviour about parsing negative numbers from 3.14 in argparse#155340
savannahostrowski merged 4 commits into
python:mainfrom
ptim0626:docs-clarify-argparse-neg-num

Conversation

@ptim0626

@ptim0626ptim0626 commented Aug 7, 2026•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels Aug 7, 2026
@bedevere-appbedevere-appBot mentioned this pull request Aug 7, 2026
Open
@read-the-docs-community

read-the-docs-communityBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33968281 | 📁 Comparing 92fe28f against main (7c653e2)

🔍 Preview build

4 files changed
±library/argparse.html
±library/inspect.html
±library/test.html
±whatsnew/changelog.html

StanFromIreland
StanFromIreland reviewed Aug 7, 2026
View reviewed changes
Comment threadDoc/library/argparse.rst Outdated
for more details.

.. versionchanged:: 3.14
Negative numbers in scientific notation (e.g. ``-2.5e-6``), with

@StanFromIrelandStanFromIrelandAug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace latin abbreviations with their English equivalents, see the style guide for more information.

@ptim0626ptim0626Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed 'e.g.' all together as spelling out 'for example' in all cases here seems too verbose.

savannahostrowski
savannahostrowski requested changes Aug 7, 2026
View reviewed changes

@savannahostrowskisavannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a slight change in wording and indentation!

Comment threadDoc/library/argparse.rst Outdated
@bedevere-app

bedevere-appBot commented Aug 7, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@savannahostrowskisavannahostrowski added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 7, 2026
@ptim0626@savannahostrowski
Rephrase and fix indentation
7d177f3
Co-authored-by: Savannah Ostrowski <savannah@python.org>
@ptim0626

ptim0626 commented Aug 7, 2026

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app

bedevere-appBot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@savannahostrowski: please review the changes made to this pull request.

savannahostrowski
savannahostrowski approved these changes Aug 8, 2026
View reviewed changes

@savannahostrowskisavannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@savannahostrowski
savannahostrowski enabled auto-merge (squash) August 8, 2026 01:34
@savannahostrowski
savannahostrowski merged commit 8ed1479 into python:mainAug 8, 2026
29 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsAug 8, 2026
@miss-islington-app

miss-islington-appBot commented Aug 8, 2026

Copy link
Copy Markdown

Thanks @ptim0626 for the PR, and @savannahostrowski for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Aug 8, 2026

Copy link
Copy Markdown

GH-155371 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 8, 2026
@bedevere-app

bedevere-appBot commented Aug 8, 2026

Copy link
Copy Markdown

GH-155372 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Aug 8, 2026
savannahostrowski added a commit that referenced this pull request Aug 8, 2026
@miss-islington@ptim0626@savannahostrowski
[3.14]gh-155339: Document the change of behaviour about parsing nega…
1b1c61a
…tive numbers from 3.14 in argparse (GH-155340) (#155372)
gh-155339: Document the change of behaviour about parsing negative numbers from 3.14 in argparse (GH-155340)
(cherry picked from commit 8ed1479)
Co-authored-by: Timothy Poon <62692924+ptim0626@users.noreply.github.com>
Co-authored-by: Savannah Ostrowski <savannah@python.org>
savannahostrowski added a commit that referenced this pull request Aug 8, 2026
@miss-islington@ptim0626@savannahostrowski
[3.15]gh-155339: Document the change of behaviour about parsing nega…
524561b
…tive numbers from 3.14 in argparse (GH-155340) (#155371)
gh-155339: Document the change of behaviour about parsing negative numbers from 3.14 in argparse (GH-155340)
(cherry picked from commit 8ed1479)
Co-authored-by: Timothy Poon <62692924+ptim0626@users.noreply.github.com>
Co-authored-by: Savannah Ostrowski <savannah@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@savannahostrowskisavannahostrowskisavannahostrowski approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ptim0626@savannahostrowski@StanFromIreland