Uh oh!
There was an error while loading. Please reload this page.
gh-85681: Make ntpath.abspath() platform independent - #155395
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-85681: Make ntpath.abspath() platform independent#155395serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
On Windows the path normalization strips trailing dots and spaces from the last component of the path, and a single trailing dot from other components. abspath() on other platforms now does the same, so relpath() and other functions based on it no longer depend on the platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ntpath.relpath()returned different results on Windows and on other platforms:relpath()is based onabspath(), which is implemented withGetFullPathNameW()on Windows. It strips trailing dots and spaces from the last component of the path, and a single trailing dot from other components, unless it is preceded by a dot. The pure Pythonabspath(), used on other platforms, now does the same.normpath()is not changed: it does not strip them on Windows either.The rules are not documented, they were determined by testing
nt._getfullpathname()on Windows 11. The added tests are run on all platforms, so they check both implementations.