Uh oh!
There was an error while loading. Please reload this page.
gh-89760: Fix os.path.realpath() for volume GUID paths on Windows - #155396
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-89760: Fix os.path.realpath() for volume GUID paths on Windows#155396serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
The \\?\ prefix was stripped from the resolved path if it could not be resolved without the prefix and failed with the same error as the original path. This produced an invalid, seemingly relative path for a junction which points to a volume without a drive letter. The prefix is now only stripped for drive-letter and UNC paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a junction points to a directory on a volume which has no drive letter,
os.path.realpath()returned a path likeVolume{<uuid>}\dir, without the\\?\prefix, which is invalid and even looks relative.The prefix was stripped because the check that the non-prefixed path resolves to the same path failed with the same error as the original path.
The prefix is now only stripped for drive-letter and UNC paths, as suggested by @eryksun.