Skip to content

gh-155835: fix digest_size data race on BLAKE-2 objects#155839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 5 commits into from
Sep 6, 2026
+10 −0
Merged

gh-155835: fix digest_size data race on BLAKE-2 objects #155839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
194cdab
gh-155835: fix `digest_size` data race on BLAKE-2 objects
picnixz Aug 15, 2026
374bfef
Update blake2module.c
picnixz Aug 15, 2026
0565277
add TSAN tests for BLAKE2
picnixz Aug 16, 2026
2693e04
Update Lib/test/test_hashlib.py
picnixz Aug 16, 2026
e6afd4a
Merge branch 'main' into meta/crypto/c/36/blake2-hash-critical-sectio…
picnixz Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/test/test_hashlib.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1505,6 +1505,12 @@ def test_HACL_sha3_attributes(self, size, attrname):
def test_HACL_shake_attributes(self, size, attrname):
self.check_HACL_attribute(_sha3, f"shake_{size}", attrname)

@requires_blake2
@support.subTests("version", ["blake2s", "blake2b"])
@support.subTests("attrname", ["block_size", "digest_size"])
def test_HACL_blake2_attributes(self, version, attrname):
self.check_HACL_attribute(_blake2, version, attrname)


if __name__ == "__main__":
unittest.main()
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-08-15-13-18-01.gh-issue-155835.mlyLWp.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
:mod:`hashlib`: Fix a data race when accessing :attr:`~hashlib.hash.digest_size`
on BLAKE-2 objects. Patch by Bénédikt Tran.
2 changes: 2 additions & 0 deletions Modules/blake2module.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -950,7 +950,9 @@ static PyObject *
py_blake2b_get_digest_size(PyObject *op, void *Py_UNUSED(closure))
{
Blake2Object *self = _Blake2Object_CAST(op);
HASHLIB_ACQUIRE_LOCK(self);
Hacl_Hash_Blake2b_index info = hacl_get_blake2_info(self);
HASHLIB_RELEASE_LOCK(self);
return PyLong_FromLong(info.digest_length);
}

Expand Down
Loading