Skip to content

bpo-37999: No longer use __int__ in implicit integer conversions. - #15636

Merged
serhiy-storchaka merged 6 commits into
python:masterfrom
serhiy-storchaka:int-implicit-lossless
May 26, 2020
Merged

bpo-37999: No longer use __int__ in implicit integer conversions.#15636
serhiy-storchaka merged 6 commits into
python:masterfrom
serhiy-storchaka:int-implicit-lossless

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Sep 1, 2019•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Only __index__ should be used to make integer conversions lossless.

https://bugs.python.org/issue37999

@serhiy-storchaka
bpo-37999: No longer use __int__ in implicit integer conversions.
dba44f0
Only __index__ should be used to make integer conversions lossless.
@serhiy-storchakaserhiy-storchaka added the type-feature A feature request or enhancement label Sep 1, 2019
serhiy-storchaka
serhiy-storchaka commented Sep 1, 2019
View reviewed changes
Comment threadDoc/whatsnew/3.9.rst Outdated
@serhiy-storchakaserhiy-storchaka changed the title [3.10] bpo-37999: No longer use __int__ in implicit integer conversions.bpo-37999: No longer use __int__ in implicit integer conversions.May 26, 2020
mdickinson
mdickinson reviewed May 26, 2020
View reviewed changes
Comment threadLib/datetime.py Outdated

@mdickinsonmdickinsonMay 26, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an effort to keep things in alphabetical order here; maybe move _index to the right place with respect to that order?

mdickinson
mdickinson reviewed May 26, 2020
View reviewed changes
Comment threadLib/test/test_math.py Outdated
mdickinson
mdickinson approved these changes May 26, 2020
View reviewed changes

@mdickinsonmdickinson left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'm happy to see this finally reach completion.

Not sure I like the OverflowError for large negative values for math.factorial: that seems like a case of the implementation details leaking into the API. EDIT: This has been changed

Just to be clear, this PR doesn't change the fact that PyNumber_Index can still return something that's an instance of a strict subclass of int. Is that correct?

@serhiy-storchaka

serhiy-storchaka commented May 26, 2020

Copy link
Copy Markdown
MemberAuthor

Just to be clear, this PR doesn't change the fact that PyNumber_Index can still return something that's an instance of a strict subclass of int. Is that correct?

Yes, it is correct.

@serhiy-storchaka
serhiy-storchaka merged commit 578c395 into python:masterMay 26, 2020
@serhiy-storchaka
serhiy-storchaka deleted the int-implicit-lossless branch May 26, 2020 15:43
@mdickinsonmdickinson mentioned this pull request May 27, 2020
Merged
@hugovkhugovk mentioned this pull request Jul 27, 2022
Merged
This was referenced Mar 17, 2023
Closed
Closed
chrisnovakovic added a commit to chrisnovakovic/cpython that referenced this pull request Mar 17, 2023
@chrisnovakovic
pythongh-102791: allow non-fractional decimal.Decimals to be interpre…
4929c3a
…ted as integers
Prior to pythongh-11952, several standard library functions that expected
integer arguments would nevertheless silently accept (and truncate)
non-integer arguments. This behaviour was deprecated in pythongh-11952, and
removed in pythongh-15636.
However, it may be possible to interpret some non-integer numeric types
(such as `decimal.Decimal`s) as integers if they contain no fractional
part. Implement `__index__` for `decimal.Decimal`, returning an integer
representation of the value if it does not contain a fractional part or
raising a `TypeError` if it does.
@bedevere-botbedevere-bot mentioned this pull request Apr 10, 2022
Closed
@skirpichevskirpichev mentioned this pull request Oct 6, 2023
Open
@bkeryanbkeryan mentioned this pull request Mar 26, 2025
Merged
1 task
bkeryan added a commit to bkeryan/hightime that referenced this pull request Mar 26, 2025
@bkeryan
hightime: Use __index__ instead of __int__
8bdb3f1
`datetime` used to accept objects that implement `__int__` or `__index__`, but in Python 3.10 it was changed to accept only `__index__`.
python/cpython#15636
@bkeryanbkeryan mentioned this pull request Mar 26, 2025
Merged
1 task
tkrebes pushed a commit to ni/hightime that referenced this pull request Apr 2, 2025
@bkeryan
hightime: Add support for Python 3.10-3.13 and drop Python 3.7-3.8 (#44)
b9913eb
* hightime: Update Python versions in tox.ini
* hightime: Update trove classifiers
* hightime: More tox.ini updates
* hightime: Use __index__ instead of __int__
`datetime` used to accept objects that implement `__int__` or `__index__`, but in Python 3.10 it was changed to accept only `__index__`.
python/cpython#15636
* github: Update Python versions
@skirpichevskirpichev mentioned this pull request Feb 8, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettingerrhettingerAwaiting requested review from rhettinger
@tirantiranAwaiting requested review from tiran
@abalkinabalkinAwaiting requested review from abalkin
@pgansslepganssleAwaiting requested review from pganssle
1 more reviewer
@mdickinsonmdickinsonmdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@mdickinson@the-knights-who-say-ni@bedevere-bot